Change in coreboot[master]: drivers/intel/gma: add macro for one internal panel in gfx struct
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49054 )
Change subject: drivers/intel/gma: add macro for one internal panel in gfx struct ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49054/1/src/drivers/intel/gma/gma.h File src/drivers/intel/gma/gma.h:
https://review.coreboot.org/c/coreboot/+/49054/1/src/drivers/intel/gma/gma.h... PS1, Line 33: /* Shortcut for one internal panel at port A */ I quote from CB:48750 what you said about this value:
type (11:8) = 0x400 (eDP = 4) port (7:4) = 0x00 (Port A = 0) zero-based index (3:0) = 0 (first display = 0)
If this value specifically designates an eDP panel, shouldn't the macro name reflect this as well?
-
Angel Pons (Code Review)