Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39127 )
Change subject: soc/intel/tigerlake: Add function to dump ME firmware status information
......................................................................
Patch Set 10:
Patch Set 10:
Hey guys. Can we implement this in src/soc/intel/common/block/cse/cse.c instead so we have a common code base. Other we would duplicate the code base
HFSTS register is not same the across SoCs. Because of this reason we cannot avoid SoC specific macros if move the function to common code. Hence, recommendation is to make the function SoC specific
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39127
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I831a51f9f482425bd3b97ef1d2404b1d06844d07
Gerrit-Change-Number: 39127
Gerrit-PatchSet: 10
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Poornima Tom
poornima.tom@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Mon, 06 Apr 2020 06:23:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment