Attention is currently required from: Arthur Heymans, Julius Werner, Maximilian Brune, Nico Huber.
Hello Julius Werner, Lean Sheng Tan, Maximilian Brune, Nico Huber, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80776?usp=email
to look at the new patch set (#3).
Change subject: lib: Declare heap in assembly ......................................................................
lib: Declare heap in assembly
Some linkers like LLD don't set up the NOBITS flag on the .heap section when just declaring that region in the linker script. This would have the program loader initialize the heap, which is not desirable for performance reasons. Also if the cbfs file would not be compressed it would be huge as the default heap is 1M.
This fixes commit 99bf23c9e73c, which broke setups with a relocatable ramstage as the heap size was not accounted for when allocating memory in cbmem. The alloc code could trash higher cbmem entries in that case.
Change-Id: I67cb5ce886fda313e0720b0bc7c6e66e4aae45fa Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/lib/Makefile.mk A src/lib/heap.S M src/lib/program.ld 3 files changed, 20 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/80776/3