[S] Change in coreboot[main]: mb/google/fatcat: Add Panther Lake SOC support - coreboot-gerrit

5 Aug 2024


      Attention is currently required from: Ashish Kumar Mishra, Felix Held, Paul Menzel, Subrata Banik.
Saurabh Mishra has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83419?usp=email )
Change subject: mb/google/fatcat: Add Panther Lake SOC support
......................................................................
Patch Set 47:
(1 comment)
File src/mainboard/google/fatcat/mainboard.c:
https://review.coreboot.org/c/coreboot/+/83419/comment/4f090341_ddcda340?usp... :
PS46, Line 24: __weak void variant_update_soc_chip_config(struct soc_intel_pantherlake_config *config)
...
For consistency, please update the syntax for __weak fn definition as line no 14 above.
Acknowledged
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83419?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5e
Gerrit-Change-Number: 83419
Gerrit-PatchSet: 47
Gerrit-Owner: Saurabh Mishra mishra.saurabh@intel.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anil Kumar K anil.kumar.k@intel.com
Gerrit-CC: Ashish Kumar Mishra ashish.k.mishra@intel.com
Gerrit-CC: Balaji Manigandan balaji.manigandan@intel.com
Gerrit-CC: Bora Guvendik bora.guvendik@intel.com
Gerrit-CC: Hannah Williams hannah.williams@intel.com
Gerrit-CC: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Ravishankar Sarawadi ravishankar.sarawadi@intel.com
Gerrit-CC: Sanju Jose Thottan sanjujose.thottan@intel.com
Gerrit-CC: Saurabh Mishra mishra.saurabh@intel.corp-partner.google.com
Gerrit-CC: Vikrant L Jadeja vikrant.l.jadeja@intel.com
Gerrit-CC: Wonkyu Kim wonkyu.kim@intel.com
Gerrit-Attention: Ashish Kumar Mishra ashish.k.mishra@intel.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 05 Aug 2024 13:55:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ashish Kumar Mishra ashish.k.mishra@intel.com