Attention is currently required from: Paul Menzel, Sergii Dmytruk, Timothy Pearson, Ron Minnich. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57082 )
Change subject: src/mainboard/emulation/qemu-power9: require hb-mode=on ......................................................................
Patch Set 12:
(7 comments)
Patchset:
PS12: I'm pretty confused about all these symbols in ramstage. Most of these are in cbmem by that time.
File src/mainboard/emulation/qemu-power9/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/57082/comment/5ed7d971_6a94e737 PS12, Line 24: STACK(0xa000000, 32K) I might be wrong but I haven't seen the stage entry move the stack pointer to this so this ends up not being consumed.
https://review.coreboot.org/c/coreboot/+/57082/comment/a4174048_23b33368 PS12, Line 27: FMAP_CACHE(0xa108000, 4K) gets migrated to cbmem.
https://review.coreboot.org/c/coreboot/+/57082/comment/34f0ef3a_25baca75 PS12, Line 28: CBFS_MCACHE(0xa109000, 8K) This gets migrated to cbmem.
https://review.coreboot.org/c/coreboot/+/57082/comment/bf647b00_62f3c274 PS12, Line 29: TIMESTAMP(0xa10b000, 4K) Is that not in cbmem in ramstage?
https://review.coreboot.org/c/coreboot/+/57082/comment/ea7751f8_0f9f9a45 PS12, Line 30: CBFS_CACHE(0xa10c000, 512K) Not sure if needed in ramstage.
https://review.coreboot.org/c/coreboot/+/57082/comment/92e69e32_5a0ecd97 PS12, Line 31: PRERAM_CBMEM_CONSOLE(0xf918c000, 128K) not needed in ramstage
-
Arthur Heymans (Code Review)