Change in ...coreboot[master]: Revert "soc/intel/skylake/romstage: Increase size of postcar stack"

[Kyösti Mälkki (Code Review)]

Hello Julius Werner, Arthur Heymans, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Patrick Georgi,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/33585

to review the following change.

Change subject: Revert "soc/intel/skylake/romstage: Increase size of postcar stack"
......................................................................

Revert "soc/intel/skylake/romstage: Increase size of postcar stack"

This reverts commit f70cb8bf968af75669325104756464ce6f4b824b.

Reason for revert: Merged prematurely with some vague argumentation in the commit message.

Change-Id: Ia336f3499fb29976a6b80383ef8b0f3d552f5640
---
M src/soc/intel/skylake/romstage/romstage_fsp20.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/33585/1

diff --git a/src/soc/intel/skylake/romstage/romstage_fsp20.c b/src/soc/intel/skylake/romstage/romstage_fsp20.c
index 0eff793..2819c6f 100644
--- a/src/soc/intel/skylake/romstage/romstage_fsp20.c
+++ b/src/soc/intel/skylake/romstage/romstage_fsp20.c
@@ -156,7 +156,7 @@
    pmc_set_disb();
    if (!s3wake)
    	save_dimm_info();
-	if (postcar_frame_init(&pcf, 8*KiB))
+	if (postcar_frame_init(&pcf, 1*KiB))
    	die("Unable to initialize postcar frame.\n");

/*

[Kyösti Mälkki (Code Review)]

Hello Julius Werner, Arthur Heymans, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33585

to look at the new patch set (#2).

Change subject: Revert "soc/intel/skylake/romstage: Increase size of postcar stack"
......................................................................

Revert "soc/intel/skylake/romstage: Increase size of postcar stack"

This reverts commit f70cb8bf968af75669325104756464ce6f4b824b.

It was merged prematurely with some vague argumentation in the commit
message and not all issues of reviewers were addressed.

Change-Id: Ia336f3499fb29976a6b80383ef8b0f3d552f5640
Signed-off-by: Kyösti Mälkki 
---
M src/soc/intel/skylake/romstage/romstage_fsp20.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/33585/2

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33585 )

Change subject: Revert "soc/intel/skylake/romstage: Increase size of postcar stack"
......................................................................

Patch Set 2:

Let's keep the discussions in CB:33775.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33585 )

Change subject: Revert "soc/intel/skylake/romstage: Increase size of postcar stack"
......................................................................

Patch Set 2: Code-Review+1

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33585 )

Change subject: Revert "soc/intel/skylake/romstage: Increase size of postcar stack"
......................................................................

Patch Set 2: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33585 )

Change subject: Revert "soc/intel/skylake/romstage: Increase size of postcar stack"
......................................................................

Patch Set 4:

@Christian Walter, @Patrick Rudolph: any comments? This has been lingering for half a week. No replies on the reverted change ( CB:33434 ) either.

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33585 )

Change subject: Revert "soc/intel/skylake/romstage: Increase size of postcar stack"
......................................................................

Patch Set 4:
> Patch Set 4:
>
> @Christian Walter, @Patrick Rudolph: any comments? This has been lingering for half a week. No replies on the reverted change ( CB:33434 ) either.

I will address the comments on the two followup patches and all these three should be ready. Just that I cannot test that FSP1_1 change CB:33927 .

Change in coreboot[master]: Revert "soc/intel/skylake/romstage: Increase size of postcar stack"

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33585 )

Change subject: Revert "soc/intel/skylake/romstage: Increase size of postcar stack"
......................................................................

Revert "soc/intel/skylake/romstage: Increase size of postcar stack"

This reverts commit f70cb8bf968af75669325104756464ce6f4b824b.

It was merged prematurely with some vague argumentation in the commit
message and not all issues of reviewers were addressed.

Change-Id: Ia336f3499fb29976a6b80383ef8b0f3d552f5640
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33585
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
Reviewed-by: Arthur Heymans 
---
M src/soc/intel/skylake/romstage/romstage_fsp20.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved
  Angel Pons: Looks good to me, but someone else must approve

diff --git a/src/soc/intel/skylake/romstage/romstage_fsp20.c b/src/soc/intel/skylake/romstage/romstage_fsp20.c
index 83fc27e..6ff59ba 100644
--- a/src/soc/intel/skylake/romstage/romstage_fsp20.c
+++ b/src/soc/intel/skylake/romstage/romstage_fsp20.c
@@ -158,7 +158,7 @@
    pmc_set_disb();
    if (!s3wake)
    	save_dimm_info();
-	if (postcar_frame_init(&pcf, 8*KiB))
+	if (postcar_frame_init(&pcf, 1*KiB))
    	die("Unable to initialize postcar frame.\n");

/*