Attention is currently required from: Furquan Shaikh, Kane Chen, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52874 )
Change subject: soc/intel/{adl, tgl, jsl}: Enable power button smi after BS_CHIPS_EXIT
......................................................................
Patch Set 5:
(2 comments)
File src/soc/intel/alderlake/cpu.c:
https://review.coreboot.org/c/coreboot/+/52874/comment/8cfd266c_5e5ec091
PS5, Line 101: /*
: * Now that all APs have been relocated as well as the BSP let SMIs
: * start flowing.
: */
Can you please update all of these comments as to the reason why the `_no_powrbtn` variant is used here?
File src/soc/intel/alderlake/pmc.c:
https://review.coreboot.org/c/coreboot/+/52874/comment/400c5a5d_fce2dc5e
PS5, Line 148: (FSPS)
nit: space after `(`, also please spell it `FSP-S`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52874
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70b871f2676a89bc782116e02beba5c20ec51eef
Gerrit-Change-Number: 52874
Gerrit-PatchSet: 5
Gerrit-Owner: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 04 May 2021 21:42:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment