Attention is currently required from: Eric Lai, Himanshu Sahdev, Kapil Porwal, Paul Menzel, Ronak Kanabar, Subrata Banik.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75529?usp=email )
Change subject: soc/intel/meteorlake: Hook up UPD PchHdaSdiEnable
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File src/soc/intel/meteorlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/75529/comment/281e425f_57325539 :
PS5, Line 228: m_cfg->PchHdaSdiEnable[i] = config->pch_hda_sdi_enable[i];
maybe memcpy?
im okay either way. i think this code is clearer than the memcpy and shouldnt be any appreciable performance difference given the few elements.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75529?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43f1e59d28fc07218f8e25266f8ce3bdcf3f6e5c
Gerrit-Change-Number: 75529
Gerrit-PatchSet: 5
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Comment-Date: Sun, 04 Jun 2023 16:12:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment