Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60025 )
Change subject: payloads/Makefile.inc: Add warning for image built with no payload ......................................................................
payloads/Makefile.inc: Add warning for image built with no payload
Writing a coreboot image without a payload to a board's flash chip will result in a non-bootable system, so warn the user if this is the case.
Signed-off-by: Nicholas Chin nic.c3.14@gmail.com Change-Id: I15ae9548a45e9f566c84db41e8e171c6bc179057 --- M payloads/Makefile.inc 1 file changed, 12 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/60025/1
diff --git a/payloads/Makefile.inc b/payloads/Makefile.inc index d89b5ba..9ee893c 100644 --- a/payloads/Makefile.inc +++ b/payloads/Makefile.inc @@ -48,5 +48,16 @@ print-repo-info-payloads: -$(foreach payload, $(PAYLOADS_LIST), $(MAKE) -C $(payload) print-repo-info 2>/dev/null; )
+ifeq ($(CONFIG_PAYLOAD_NONE),y) +files_added:: warn_no_payload +endif + +warn_no_payload: + printf "\n\t** WARNING **\n" + printf "coreboot has been built without a payload.\n" + printf "Writing a coreboot image without a payload to your board's\n" + printf "flash chip will result in a non-booting system.\n" + printf "You can use cbfstool to add a payload to the image.\n\n" + .PHONY: force-payload coreinfo nvramcui -.PHONY: clean-payloads distclean-payloads print-repo-info-payloads +.PHONY: clean-payloads distclean-payloads print-repo-info-payloads warn_no_payload