Change in coreboot[master]: payloads/filo: Set stable tag to something that builds

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Nico Huber (Code Review)

27 Oct 2020 27 Oct '20

11:57 a.m.

Hello Felix Singer,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/46849

to review the following change.

Change subject: payloads/filo: Set stable tag to something that builds ......................................................................

payloads/filo: Set stable tag to something that builds

Also rename the prompt to "tested" to make it more obvious that there is no really stable version.

Change-Id: Ib719fe5c30783a53ddad2a2dc2d9ecda37a05ac2 Signed-off-by: Nico Huber nico.h@gmx.de --- M payloads/external/FILO/Kconfig M payloads/external/FILO/Makefile 2 files changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/46849/1

diff --git a/payloads/external/FILO/Kconfig b/payloads/external/FILO/Kconfig index 94d5e18..1cf171d 100644 --- a/payloads/external/FILO/Kconfig +++ b/payloads/external/FILO/Kconfig @@ -5,9 +5,9 @@ default FILO_STABLE

config FILO_STABLE - bool "0.6.0" + bool "tested" help - Stable FILO version + Tested FILO version

config FILO_MASTER bool "HEAD" diff --git a/payloads/external/FILO/Makefile b/payloads/external/FILO/Makefile index a89ea2a..6175cfe 100644 --- a/payloads/external/FILO/Makefile +++ b/payloads/external/FILO/Makefile @@ -1,6 +1,6 @@ TAG-$(CONFIG_FILO_MASTER)=origin/master NAME-$(CONFIG_FILO_MASTER)=MASTER -TAG-$(CONFIG_FILO_STABLE)=22baa6bde9339029edfafa421b3d4a7be159edad +TAG-$(CONFIG_FILO_STABLE)=c2fa1ea6125c63e84cdf7779c37d76da8c5bc412 NAME-$(CONFIG_FILO_STABLE)=STABLE

project_git_repo=https://review.coreboot.org/filo.git

Attachments:

attachment.htm (text/html — 3.4 KB)

Show replies by date

Paul Menzel (Code Review)

27 Oct 27 Oct

1:10 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46849 )

Change subject: payloads/filo: Set stable tag to something that builds ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/46849/1/payloads/external/FILO/Kcon... File payloads/external/FILO/Kconfig:

https://review.coreboot.org/c/coreboot/+/46849/1/payloads/external/FILO/Kcon... PS1, Line 7: FILO_STABLE Update the name too?

-- To view, visit https://review.coreboot.org/c/coreboot/+/46849 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib719fe5c30783a53ddad2a2dc2d9ecda37a05ac2 Gerrit-Change-Number: 46849 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 27 Oct 2020 20:10:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

3:11 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46849 )

Change subject: payloads/filo: Set stable tag to something that builds ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46849/1/payloads/external/FILO/Kcon... File payloads/external/FILO/Kconfig:

https://review.coreboot.org/c/coreboot/+/46849/1/payloads/external/FILO/Kcon... PS1, Line 7: FILO_STABLE

...

Update the name too?

I only kept it so it's easy to change things back to our default stable vs. master choice. If I'd change it, I could as well just drop the whole choice.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46849 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib719fe5c30783a53ddad2a2dc2d9ecda37a05ac2 Gerrit-Change-Number: 46849 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 27 Oct 2020 22:11:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Angel Pons (Code Review)

4:42 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46849 )

Change subject: payloads/filo: Set stable tag to something that builds ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46849 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib719fe5c30783a53ddad2a2dc2d9ecda37a05ac2 Gerrit-Change-Number: 46849 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 27 Oct 2020 23:42:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

4:42 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46849 )

Change subject: payloads/filo: Set stable tag to something that builds ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46849/1/payloads/external/FILO/Kcon... File payloads/external/FILO/Kconfig:

https://review.coreboot.org/c/coreboot/+/46849/1/payloads/external/FILO/Kcon... PS1, Line 7: FILO_STABLE

...

I only kept it so it's easy to change things back to our default […]

I completely agree with the reasoning.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46849 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib719fe5c30783a53ddad2a2dc2d9ecda37a05ac2 Gerrit-Change-Number: 46849 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 27 Oct 2020 23:42:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Felix Singer (Code Review)

11:06 p.m.

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46849 )

Change subject: payloads/filo: Set stable tag to something that builds ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46849 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib719fe5c30783a53ddad2a2dc2d9ecda37a05ac2 Gerrit-Change-Number: 46849 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 28 Oct 2020 06:06:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

28 Oct 28 Oct

12:32 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46849 )

Change subject: payloads/filo: Set stable tag to something that builds ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46849/1/payloads/external/FILO/Kcon... File payloads/external/FILO/Kconfig:

https://review.coreboot.org/c/coreboot/+/46849/1/payloads/external/FILO/Kcon... PS1, Line 7: FILO_STABLE

...

I completely agree with the reasoning.

True, didn’t think of that.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46849 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib719fe5c30783a53ddad2a2dc2d9ecda37a05ac2 Gerrit-Change-Number: 46849 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 28 Oct 2020 07:32:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Nico Huber (Code Review)

4:42 p.m.

Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46849 )

Change subject: payloads/filo: Set stable tag to something that builds ......................................................................

payloads/filo: Set stable tag to something that builds

Also rename the prompt to "tested" to make it more obvious that there is no really stable version.

Change-Id: Ib719fe5c30783a53ddad2a2dc2d9ecda37a05ac2 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/46849 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Felix Singer felixsinger@posteo.net --- M payloads/external/FILO/Kconfig M payloads/external/FILO/Makefile 2 files changed, 3 insertions(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved

config FILO_STABLE - bool "0.6.0" + bool "tested" help - Stable FILO version + Tested FILO version

project_git_repo=https://review.coreboot.org/filo.git

-- To view, visit https://review.coreboot.org/c/coreboot/+/46849 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib719fe5c30783a53ddad2a2dc2d9ecda37a05ac2 Gerrit-Change-Number: 46849 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1481

days inactive

1482

days old

coreboot-gerrit@coreboot.org

7 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Felix Singer (Code Review)
Nico Huber (Code Review)
Paul Menzel (Code Review)