Attention is currently required from: Martin Roth, Matt DeVillier, Tim Wawrzynczak, Karthik Ramasubramanian.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59266 )
Change subject: util/chromeos: Update extract_blobs script
......................................................................
Patch Set 3:
(1 comment)
File util/chromeos/extract_blobs.sh:
https://review.coreboot.org/c/coreboot/+/59266/comment/b3c4e357_488f8364
PS1, Line 102:
AFAIK, every board in the tree that requires a spd.bin has it generated as part of the build.
SPDs are data, they can and should be part of the coreboot repo. Mainboards should already provide them.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59266
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idaa39eca3be68a9327cead9b21c35a6c7a3a8166
Gerrit-Change-Number: 59266
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 15 Nov 2021 16:27:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment