Attention is currently required from: Felix Held, Fred Reitberger, Grzegorz Bernacki, Jason Glenesk, Jason Nien, Jon Murphy, Martin Roth, Matt DeVillier, Paul Menzel, Raul Rangel, Yu-Ping Wu.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75621?usp=email )
Change subject: mb/google: AMD: move tpm_tis to AMD common code
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/common/block/gpio/Kconfig:
https://review.coreboot.org/c/coreboot/+/75621/comment/f0dcbfac_025a1e76 :
PS3, Line 22: TPM_TIS_INTERRUPT
```TPM_TIS_INTERRUPT``` is used for Intel platform, I think it make sense to use the same name
I was thinking the same thing about this name as Yu-Ping. Is it a GPIO on Intel as well?
Maybe change it to TPM_IRQ_GPIO on both in a follow-on patch?
This isn't an interrupt number, so in my opinion shouldn't be named "XXX_INTERUPT".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75621?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I775c4e24cffee99b6ac3e05b58a75425029a86c8
Gerrit-Change-Number: 75621
Gerrit-PatchSet: 3
Gerrit-Owner: Grzegorz Bernacki
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Grzegorz Bernacki
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 28 Jun 2023 19:57:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Grzegorz Bernacki
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment