Change in coreboot[master]: tests: Add lib/cbfs-verification-test test case - coreboot-gerrit

19 Aug 2021


      Attention is currently required from: Julius Werner, Jan Dabros.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56601 )
Change subject: tests: Add lib/cbfs-verification-test test case
......................................................................
Patch Set 9:
(1 comment)
File tests/lib/cbfs-verification-test.c:
https://review.coreboot.org/c/coreboot/+/56601/comment/093a1036_d4fa41c0 
PS2, Line 4: #define __noreturn
...
Resolved?
I think so. die() from tests/stubs/die.c calls fail() which then calls either abort(), exit(-1), or longjmp(). All listed function are __noreturn (at least for my GCC and its headers). Do we really need to mark _fail() as __noreturn?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56601
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d8cbb1c2d0a9db3236de065428b70a9c2a66330
Gerrit-Change-Number: 56601
Gerrit-PatchSet: 9
Gerrit-Owner: Jakub Czapiga jacz@semihalf.com
Gerrit-Reviewer: Jan Dabros jsd@semihalf.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Jan Dabros jsd@semihalf.com
Gerrit-Comment-Date: Thu, 19 Aug 2021 14:35:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga jacz@semihalf.com
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment