Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36106 )
Change subject: google/poppy: add VBT for nautilus variant ......................................................................
google/poppy: add VBT for nautilus variant
Add data.vbt and modify Kconfig appropriately
Change-Id: I8a2d093ad96f72fb420b94aafa790e3ba900d905 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/poppy/Kconfig A src/mainboard/google/poppy/variants/nautilus/data.vbt 2 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/36106/1
diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig index 07e3990..85dc9a5 100644 --- a/src/mainboard/google/poppy/Kconfig +++ b/src/mainboard/google/poppy/Kconfig @@ -10,7 +10,7 @@ select EC_GOOGLE_CHROMEEC_ESPI select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES - select INTEL_GMA_HAVE_VBT if BOARD_GOOGLE_NAMI + select INTEL_GMA_HAVE_VBT if BOARD_GOOGLE_NAMI || BOARD_GOOGLE_NAUTILUS select INTEL_LPSS_UART_FOR_CONSOLE select MAINBOARD_HAS_CHROMEOS select SOC_INTEL_KABYLAKE diff --git a/src/mainboard/google/poppy/variants/nautilus/data.vbt b/src/mainboard/google/poppy/variants/nautilus/data.vbt new file mode 100644 index 0000000..9524805 --- /dev/null +++ b/src/mainboard/google/poppy/variants/nautilus/data.vbt Binary files differ
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36106 )
Change subject: google/poppy: add VBT for nautilus variant ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/36106/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36106/1//COMMIT_MSG@9 PS1, Line 9: Add data.vbt and modify Kconfig appropriately Does it fix anything in particular? Where was the file taken from?
Hello Angel Pons, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36106
to look at the new patch set (#2).
Change subject: google/poppy: add VBT for nautilus variant ......................................................................
google/poppy: add VBT for nautilus variant
Add data.vbt and modify Kconfig appropriately; allows use of FSP/GOP display init.
VBT extracted from stock ChromeOS firmware.
Change-Id: I8a2d093ad96f72fb420b94aafa790e3ba900d905 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/poppy/Kconfig A src/mainboard/google/poppy/variants/nautilus/data.vbt 2 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/36106/2
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36106 )
Change subject: google/poppy: add VBT for nautilus variant ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36106/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36106/1//COMMIT_MSG@9 PS1, Line 9: Add data.vbt and modify Kconfig appropriately
Does it fix anything in particular? Where was the file taken from?
edited commit msg to answer these
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36106 )
Change subject: google/poppy: add VBT for nautilus variant ......................................................................
google/poppy: add VBT for nautilus variant
Add data.vbt and modify Kconfig appropriately; allows use of FSP/GOP display init.
VBT extracted from stock ChromeOS firmware.
Change-Id: I8a2d093ad96f72fb420b94aafa790e3ba900d905 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36106 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/google/poppy/Kconfig A src/mainboard/google/poppy/variants/nautilus/data.vbt 2 files changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig index 07e3990..85dc9a5 100644 --- a/src/mainboard/google/poppy/Kconfig +++ b/src/mainboard/google/poppy/Kconfig @@ -10,7 +10,7 @@ select EC_GOOGLE_CHROMEEC_ESPI select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES - select INTEL_GMA_HAVE_VBT if BOARD_GOOGLE_NAMI + select INTEL_GMA_HAVE_VBT if BOARD_GOOGLE_NAMI || BOARD_GOOGLE_NAUTILUS select INTEL_LPSS_UART_FOR_CONSOLE select MAINBOARD_HAS_CHROMEOS select SOC_INTEL_KABYLAKE diff --git a/src/mainboard/google/poppy/variants/nautilus/data.vbt b/src/mainboard/google/poppy/variants/nautilus/data.vbt new file mode 100644 index 0000000..9524805 --- /dev/null +++ b/src/mainboard/google/poppy/variants/nautilus/data.vbt Binary files differ
-
Matt DeVillier (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)