[S] Change in coreboot[main]: sb/intel/i82801gx/lpc.c: Refactor i82801gx_gpi_routing() - coreboot-gerrit

17 Jul 2024


      Attention is currently required from: Elyes Haouas.
Paul Menzel has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83492?usp=email )
Change subject: sb/intel/i82801gx/lpc.c: Refactor i82801gx_gpi_routing()
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83492/comment/74c1335c_b22593ec?usp... :
PS3, Line 8: 
Please elaborate why the new version is better.
File src/southbridge/intel/i82801gx/lpc.c:
https://review.coreboot.org/c/coreboot/+/83492/comment/a8c592bd_5e4ecefa?usp... :
PS3, Line 118: 	int i;
size_t?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83492?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie6ad4d481d9e1194ca971710cce55e8fc639f826
Gerrit-Change-Number: 83492
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Elyes Haouas ehaouas@noos.fr
Gerrit-Comment-Date: Wed, 17 Jul 2024 04:33:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No