Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74583 )
Change subject: mb/google/skyrim/var/markarth: Change to read the eMMC clkreq instead
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/skyrim/variants/markarth/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/74583/comment/3ab3106f_71e78578
PS4, Line 77: 115
Just a note: This change is functionally right. But in the future instead of number, I would prefer to use GPIO_115 as defined in soc/gpio.h. Jon is working on fixing it for Skyrim program - atleast fixable for port_descriptors.c. So no further effort required.
We learnt that in older SoCs, GPIO_NNN != NNN.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74583
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a9225473a6ae1ba01dc8e5d982c4999f073267e
Gerrit-Change-Number: 74583
Gerrit-PatchSet: 4
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Chao Gui
chaogui@google.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Patrick Huang
patrick.huang@amd.corp-partner.google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Rex Chou
rex_chou@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Mon, 24 Apr 2023 15:23:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment