Change in coreboot[4.11_branch]: mb/facebook/watson: increase size of RO_VPD and RW_VPD for Watson
Jonathan Zhang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44531 )
Change subject: mb/facebook/watson: increase size of RO_VPD and RW_VPD for Watson ......................................................................
mb/facebook/watson: increase size of RO_VPD and RW_VPD for Watson
The current size of RO_VPD (and RW_VPD) is too small. We have case that adding VPD parameters silently corrupts the coreboot region next to RO_VPD.
TESTED=build coreboot image for watson, add large size VPD parameter to the image, boot watson server into target OS.
Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: I428b7de6462b47492d9526042018395d2f99cb2a --- M src/mainboard/facebook/watson/board.fmd 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/44531/1
diff --git a/src/mainboard/facebook/watson/board.fmd b/src/mainboard/facebook/watson/board.fmd index e2b8f58..6c58d12 100644 --- a/src/mainboard/facebook/watson/board.fmd +++ b/src/mainboard/facebook/watson/board.fmd @@ -9,8 +9,8 @@ FMAP@0x0 0x1000 RW_MISC@0x1000 0xe000 { RW_ELOG@0x0 0x4000 - RW_VPD@0x4000 0x2000 - RW_MISC_UNUSED@0x6000 0x5000 + RW_VPD@0x4000 0x4000 + RW_MISC_UNUSED@0x8000 0x4000 RW_NVRAM@0xc000 0x2000 } UNIFIED_MRC_CACHE@0x10000 0x20000 { @@ -19,7 +19,7 @@ } # This only exists to satisfy tools that specifically # look for RO_VPD. - RO_VPD@0x30000 0x1000 - COREBOOT(CBFS)@0x31000 0x9cf000 + RO_VPD@0x30000 0x4000 + COREBOOT(CBFS)@0x34000 } }
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44531 )
Change subject: mb/facebook/watson: increase size of RO_VPD and RW_VPD for Watson ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44531 )
Change subject: mb/facebook/watson: increase size of RO_VPD and RW_VPD for Watson ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/44531/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44531/1//COMMIT_MSG@7 PS1, Line 7: for Watson Redundant with prefix.
https://review.coreboot.org/c/coreboot/+/44531/1//COMMIT_MSG@7 PS1, Line 7: mb/facebook/watson: increase size of RO_VPD and RW_VPD for Watson Please explicitly mention the new size.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44531 )
Change subject: mb/facebook/watson: increase size of RO_VPD and RW_VPD for Watson ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44531/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44531/1//COMMIT_MSG@7 PS1, Line 7: for Watson
Redundant with prefix.
Done
https://review.coreboot.org/c/coreboot/+/44531/1//COMMIT_MSG@7 PS1, Line 7: mb/facebook/watson: increase size of RO_VPD and RW_VPD for Watson
Please explicitly mention the new size.
Done
Hello Philipp Deppenwiese, build bot (Jenkins), Paul Menzel, insomniac, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44531
to look at the new patch set (#2).
Change subject: mb/facebook/watson: increase size of RO_VPD and RW_VPD ......................................................................
mb/facebook/watson: increase size of RO_VPD and RW_VPD
The current size of RO_VPD (and RW_VPD) is too small. We have case that adding VPD parameters silently corrupts the coreboot region next to RO_VPD.
Increase the size of both RO_VPD and RW_VPD to 0x4000 bytes.
TESTED=build coreboot image for watson, add large size VPD parameter to the image, boot watson server into target OS.
Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: I428b7de6462b47492d9526042018395d2f99cb2a --- M src/mainboard/facebook/watson/board.fmd 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/44531/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44531 )
Change subject: mb/facebook/watson: increase size of RO_VPD and RW_VPD ......................................................................
Patch Set 2:
Build error seems unrelated:
ERROR: Timeout after 10 minutes ERROR: Error cloning remote repo 'origin'
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44531 )
Change subject: mb/facebook/watson: increase size of RO_VPD and RW_VPD ......................................................................
mb/facebook/watson: increase size of RO_VPD and RW_VPD
The current size of RO_VPD (and RW_VPD) is too small. We have case that adding VPD parameters silently corrupts the coreboot region next to RO_VPD.
Increase the size of both RO_VPD and RW_VPD to 0x4000 bytes.
TESTED=build coreboot image for watson, add large size VPD parameter to the image, boot watson server into target OS.
Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: I428b7de6462b47492d9526042018395d2f99cb2a Reviewed-on: https://review.coreboot.org/c/coreboot/+/44531 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/mainboard/facebook/watson/board.fmd 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/facebook/watson/board.fmd b/src/mainboard/facebook/watson/board.fmd index e2b8f58..6c58d12 100644 --- a/src/mainboard/facebook/watson/board.fmd +++ b/src/mainboard/facebook/watson/board.fmd @@ -9,8 +9,8 @@ FMAP@0x0 0x1000 RW_MISC@0x1000 0xe000 { RW_ELOG@0x0 0x4000 - RW_VPD@0x4000 0x2000 - RW_MISC_UNUSED@0x6000 0x5000 + RW_VPD@0x4000 0x4000 + RW_MISC_UNUSED@0x8000 0x4000 RW_NVRAM@0xc000 0x2000 } UNIFIED_MRC_CACHE@0x10000 0x20000 { @@ -19,7 +19,7 @@ } # This only exists to satisfy tools that specifically # look for RO_VPD. - RO_VPD@0x30000 0x1000 - COREBOOT(CBFS)@0x31000 0x9cf000 + RO_VPD@0x30000 0x4000 + COREBOOT(CBFS)@0x34000 } }
-
Angel Pons (Code Review) -
Jonathan Zhang (Code Review)
-
Paul Menzel (Code Review)