Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47480 )
Change subject: mb/amd/mandolin/Kconfig: add comment on the EC blob ......................................................................
mb/amd/mandolin/Kconfig: add comment on the EC blob
Change-Id: If8d3ebdb9a41330312c26fb5796c07de1b87b3eb Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/mandolin/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/47480/1
diff --git a/src/mainboard/amd/mandolin/Kconfig b/src/mainboard/amd/mandolin/Kconfig index f4032d4..c144fd9 100644 --- a/src/mainboard/amd/mandolin/Kconfig +++ b/src/mainboard/amd/mandolin/Kconfig @@ -72,6 +72,8 @@ depends on MANDOLIN_HAVE_MCHP_FW default "3rdparty/blobs/mainboard/amd/mandolin/EC_mandolin.bin" if BOARD_AMD_MANDOLIN default "3rdparty/blobs/mainboard/amd/mandolin/EC_cereme.bin" if BOARD_AMD_CEREME + help + The EC firmware blob is usually the first 128kByte of the stock firmware image.
if !AMD_LPC_DEBUG_CARD choice
Hello Jason Glenesk, Marshall Dawson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47480
to look at the new patch set (#2).
Change subject: mb/amd/mandolin/Kconfig: add comment on the EC blob ......................................................................
mb/amd/mandolin/Kconfig: add comment on the EC blob
Change-Id: If8d3ebdb9a41330312c26fb5796c07de1b87b3eb Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/mandolin/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/47480/2
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47480 )
Change subject: mb/amd/mandolin/Kconfig: add comment on the EC blob ......................................................................
Patch Set 2: Code-Review+2
Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47480 )
Change subject: mb/amd/mandolin/Kconfig: add comment on the EC blob ......................................................................
Patch Set 2: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47480 )
Change subject: mb/amd/mandolin/Kconfig: add comment on the EC blob ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47480/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47480/2//COMMIT_MSG@7 PS2, Line 7: comment Maybe:
Add help text for the EC blob
Hello Jason Glenesk, build bot (Jenkins), Marshall Dawson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47480
to look at the new patch set (#3).
Change subject: mb/amd/mandolin/Kconfig: add help text for the EC blob ......................................................................
mb/amd/mandolin/Kconfig: add help text for the EC blob
Change-Id: If8d3ebdb9a41330312c26fb5796c07de1b87b3eb Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/mandolin/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/47480/3
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47480 )
Change subject: mb/amd/mandolin/Kconfig: add help text for the EC blob ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47480/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47480/2//COMMIT_MSG@7 PS2, Line 7: comment
Maybe: […]
yep, that makes is more specific. updated the commit message
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47480 )
Change subject: mb/amd/mandolin/Kconfig: add help text for the EC blob ......................................................................
mb/amd/mandolin/Kconfig: add help text for the EC blob
Change-Id: If8d3ebdb9a41330312c26fb5796c07de1b87b3eb Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/47480 Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-by: Jason Glenesk jason.glenesk@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/amd/mandolin/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved Jason Glenesk: Looks good to me, but someone else must approve
diff --git a/src/mainboard/amd/mandolin/Kconfig b/src/mainboard/amd/mandolin/Kconfig index f4032d4..099f7cb 100644 --- a/src/mainboard/amd/mandolin/Kconfig +++ b/src/mainboard/amd/mandolin/Kconfig @@ -72,6 +72,9 @@ depends on MANDOLIN_HAVE_MCHP_FW default "3rdparty/blobs/mainboard/amd/mandolin/EC_mandolin.bin" if BOARD_AMD_MANDOLIN default "3rdparty/blobs/mainboard/amd/mandolin/EC_cereme.bin" if BOARD_AMD_CEREME + help + The EC firmware blob is usually the first 128kByte of the stock + firmware image.
if !AMD_LPC_DEBUG_CARD choice
-
Felix Held (Code Review) -
Jason Glenesk (Code Review)
-
Marshall Dawson (Code Review)
-
Paul Menzel (Code Review)