[S] Change in coreboot[main]: libpayload: add more condition to check valid PCI device id

[Subrata Banik (Code Review)]

Attention is currently required from: Anil Kumar K, Bora Guvendik, Jamie Ryu, Jeremy Compostella, Wonkyu Kim.

Subrata Banik has posted comments on this change by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/84229?usp=email )

Change subject: libpayload: add more condition to check valid PCI device id
......................................................................

Patch Set 3:

(3 comments)

File payloads/libpayload/drivers/usb/usbinit.c:

https://review.coreboot.org/c/coreboot/+/84229/comment/3bba86af_4b3375b3?usp... :
PS3, Line 126: 		/* Check if there's a device here at all. */
             : 		if (pci_read_config32(pci_device, REG_VENDOR_ID) == 0xffffffff)
please specify the device where you have ran into this issue. IMO, checking VID itself for 0xFFFF is enough as per PCI spec. we don't need to check both VID:DID.

Are you seeing platform device, that has valid VID and NULL DID? This sounds to me a bad hardware or configuration.

https://review.coreboot.org/c/coreboot/+/84229/comment/6a228548_a9882b7c?usp... :
PS3, Line 141: 
why ?

https://review.coreboot.org/c/coreboot/+/84229/comment/8eb0fbbf_e73b09ac?usp... :
PS3, Line 147:  
space ?