Attention is currently required from: Vladimir Serbinenko.
Paul Menzel has posted comments on this change by Vladimir Serbinenko. ( https://review.coreboot.org/c/coreboot/+/82737?usp=email )
Change subject: it8728f: Support setting power state after power failure ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82737/comment/63b35d31_73e3409b?usp... : PS1, Line 7: it8728f superio/ite/it8728f
https://review.coreboot.org/c/coreboot/+/82737/comment/3ad4810b_17a6aef9?usp... : PS1, Line 9: Tested on GA-H61M-S2PV Maybe mention power_on_after_fail
File src/superio/ite/it8728f/superio.c:
https://review.coreboot.org/c/coreboot/+/82737/comment/c50e4203_655b37c8?usp... : PS1, Line 42: if (power_status == MAINBOARD_POWER_ON) : byte_f4 |= 0x20; Please add {} around the branch, as at least one other branch uses them.