Change in coreboot[master]: util/testing: Build test more of our tools

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Patrick Georgi (Code Review)

11 Nov 2020 11 Nov '20

9:51 a.m.

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47446 )

Change subject: util/testing: Build test more of our tools ......................................................................

util/testing: Build test more of our tools

https://qa.coreboot.org/job/untested-coreboot-files reports a bunch of untouched Makefiles, so we never even attempt to build those tools.

Change-Id: I70ca658d9642b84fa8388c72ecb83327a6a74291 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/testing/Makefile.inc 1 file changed, 6 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/47446/1

diff --git a/util/testing/Makefile.inc b/util/testing/Makefile.inc index d094196..20f19d9 100644 --- a/util/testing/Makefile.inc +++ b/util/testing/Makefile.inc @@ -54,10 +54,15 @@ cbmem \ ectool \ futility \ +genprof \ +intelmetool \ inteltool \ intelvbttool \ nvramtool \ -superiotool +post \ +superiotool \ +uio_usbdebug \ +vgabios

TEST_PAYLOADLIST_INTERNAL= \ coreinfo \

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Idwer Vollering (Code Review)

5 Jan 5 Jan

3:04 p.m.

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47446 )

Change subject: util/testing: Build test more of our tools ......................................................................

Patch Set 2:

amdfwtool is not added. Is that intentional?

-- To view, visit https://review.coreboot.org/c/coreboot/+/47446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70ca658d9642b84fa8388c72ecb83327a6a74291 Gerrit-Change-Number: 47446 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Idwer Vollering vidwer@gmail.com Gerrit-Comment-Date: Tue, 05 Jan 2021 15:04:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

7:44 p.m.

Hello build bot (Jenkins), Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47446

to look at the new patch set (#3).

Change subject: util/testing: Build test more of our tools ......................................................................

util/testing: Build test more of our tools

https://qa.coreboot.org/job/untested-coreboot-files reports a bunch of untouched Makefiles, so we never even attempt to build those tools.

Change-Id: I70ca658d9642b84fa8388c72ecb83327a6a74291 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/testing/Makefile.inc 1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/47446/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/47446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70ca658d9642b84fa8388c72ecb83327a6a74291 Gerrit-Change-Number: 47446 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Idwer Vollering vidwer@gmail.com Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

7:44 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47446 )

Change subject: util/testing: Build test more of our tools ......................................................................

Patch Set 2:

...

Patch Set 2:

amdfwtool is not added. Is that intentional?

It was just a rebase to figure out what's broken (to split that out into a separate commit)

-- To view, visit https://review.coreboot.org/c/coreboot/+/47446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70ca658d9642b84fa8388c72ecb83327a6a74291 Gerrit-Change-Number: 47446 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Idwer Vollering vidwer@gmail.com Gerrit-Comment-Date: Tue, 05 Jan 2021 19:44:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Martin Roth (Code Review)

6 Jan 6 Jan

4:04 p.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47446 )

Change subject: util/testing: Build test more of our tools ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70ca658d9642b84fa8388c72ecb83327a6a74291 Gerrit-Change-Number: 47446 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Idwer Vollering vidwer@gmail.com Gerrit-Comment-Date: Wed, 06 Jan 2021 16:04:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Singer (Code Review)

4:09 p.m.

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47446 )

Change subject: util/testing: Build test more of our tools ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70ca658d9642b84fa8388c72ecb83327a6a74291 Gerrit-Change-Number: 47446 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Idwer Vollering vidwer@gmail.com Gerrit-Comment-Date: Wed, 06 Jan 2021 16:09:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

4:28 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47446 )

Change subject: util/testing: Build test more of our tools ......................................................................

util/testing: Build test more of our tools

https://qa.coreboot.org/job/untested-coreboot-files reports a bunch of untouched Makefiles, so we never even attempt to build those tools.

Change-Id: I70ca658d9642b84fa8388c72ecb83327a6a74291 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47446 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Felix Singer felixsinger@posteo.net --- M util/testing/Makefile.inc 1 file changed, 4 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Felix Singer: Looks good to me, approved

diff --git a/util/testing/Makefile.inc b/util/testing/Makefile.inc index 989fe69..da6db60 100644 --- a/util/testing/Makefile.inc +++ b/util/testing/Makefile.inc @@ -51,12 +51,16 @@ echo

TOOLLIST= \ +amdfwtool \ cbmem \ ectool \ futility \ +genprof \ +intelmetool \ inteltool \ intelvbttool \ nvramtool \ +post \ superiotool

TEST_PAYLOADLIST_INTERNAL= \

-- To view, visit https://review.coreboot.org/c/coreboot/+/47446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70ca658d9642b84fa8388c72ecb83327a6a74291 Gerrit-Change-Number: 47446 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Idwer Vollering vidwer@gmail.com Gerrit-MessageType: merged

1368

days inactive

1424

days old

coreboot-gerrit@coreboot.org

6 comments

4 participants

tags (0)

participants (4)

Felix Singer (Code Review)
Idwer Vollering (Code Review)
Martin Roth (Code Review)
Patrick Georgi (Code Review)