Attention is currently required from: Angel Pons, Arthur Heymans, Lean Sheng Tan, Patrick Rudolph, Vasiliy Khoruzhick, yuchi.chen@intel.com.
Shuo Liu has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/85283?usp=email )
Change subject: soc/intel/common/block: Add const qualifier for input of pirq ops
......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/itss.h:
https://review.coreboot.org/c/coreboot/+/85283/comment/334c3bf2_7dccbf90?usp... :
PS5, Line 51: uint32_t itss_soc_get_on_chip_dev_pir(const struct device *dev);
Snow Ridge is also using this function, I'm wondering why compiler doesn't complain about this incon […]
I add changes for snowridge, could you please check if this is working on it?
P.S. a function by const struct *device can accept a non-const input, but cannot vice versa.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85283?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I65b4de3f51b109bfcabfaa0ebe47a22bdd69d1a0
Gerrit-Change-Number: 85283
Gerrit-PatchSet: 6
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Vasiliy Khoruzhick
vasilykh@arista.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: yuchi.chen@intel.com
Gerrit-Attention: yuchi.chen@intel.com
Gerrit-Attention: Vasiliy Khoruzhick
vasilykh@arista.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Mon, 09 Dec 2024 01:26:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: yuchi.chen@intel.com