Change in coreboot[master]: intel/common/blk/pcie: Add Null and 0 count check in pcie_rp_update_d... - coreboot-gerrit

27 Jan 2022


      Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Patrick Rudolph.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61331 )
Change subject: intel/common/blk/pcie: Add Null and 0 count check in pcie_rp_update_devtree
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/common/block/pcie/pcie_rp.c:
https://review.coreboot.org/c/coreboot/+/61331/comment/a83f15dc_801c0811 
PS5, Line 133: &&
use "or" here? if the groups is NULL, the second check will crash.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/61331
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I132319bb05fdef1590c18302fc64cc76e15bea6d
Gerrit-Change-Number: 61331
Gerrit-PatchSet: 5
Gerrit-Owner: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Thu, 27 Jan 2022 06:17:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment