Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31198
Change subject: mb/ocp/wedge100s: Remove MAINBOARD_USES_IFD_GBE_REGION ......................................................................
mb/ocp/wedge100s: Remove MAINBOARD_USES_IFD_GBE_REGION
It has 2x 10GbE XGMII and 1x i210IT on PCIe, but no GBE.
Change-Id: I641c336350a0b05f3db7603cc7f6281ff3b0c388 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/mainboard/ocp/wedge100s/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/31198/1
diff --git a/src/mainboard/ocp/wedge100s/Kconfig b/src/mainboard/ocp/wedge100s/Kconfig index 846d979..bd5e665 100644 --- a/src/mainboard/ocp/wedge100s/Kconfig +++ b/src/mainboard/ocp/wedge100s/Kconfig @@ -16,7 +16,6 @@ select MAINBOARD_HAS_TPM1 select DRIVERS_UART_8250IO select SUPERIO_ITE_IT8528E - select MAINBOARD_USES_IFD_GBE_REGION
config VBOOT select VBOOT_VBNV_CMOS
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31198 )
Change subject: mb/ocp/wedge100s: Remove MAINBOARD_USES_IFD_GBE_REGION ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31198 )
Change subject: mb/ocp/wedge100s: Remove MAINBOARD_USES_IFD_GBE_REGION ......................................................................
Patch Set 1:
Is the devicetree wrong, too?
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31198 )
Change subject: mb/ocp/wedge100s: Remove MAINBOARD_USES_IFD_GBE_REGION ......................................................................
Patch Set 1:
Patch Set 1:
Is the devicetree wrong, too?
Yes, but there's so much wrong that I'll create a new commit for that...
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31198 )
Change subject: mb/ocp/wedge100s: Remove MAINBOARD_USES_IFD_GBE_REGION ......................................................................
mb/ocp/wedge100s: Remove MAINBOARD_USES_IFD_GBE_REGION
It has 2x 10GbE XGMII and 1x i210IT on PCIe, but no GBE.
Change-Id: I641c336350a0b05f3db7603cc7f6281ff3b0c388 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/31198 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Philipp Deppenwiese zaolin.daisuki@gmail.com --- M src/mainboard/ocp/wedge100s/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Philipp Deppenwiese: Looks good to me, approved
diff --git a/src/mainboard/ocp/wedge100s/Kconfig b/src/mainboard/ocp/wedge100s/Kconfig index 846d979..bd5e665 100644 --- a/src/mainboard/ocp/wedge100s/Kconfig +++ b/src/mainboard/ocp/wedge100s/Kconfig @@ -16,7 +16,6 @@ select MAINBOARD_HAS_TPM1 select DRIVERS_UART_8250IO select SUPERIO_ITE_IT8528E - select MAINBOARD_USES_IFD_GBE_REGION
config VBOOT select VBOOT_VBNV_CMOS
-
Nico Huber (Code Review) -
Patrick Rudolph (Code Review)
-
Philipp Deppenwiese (Code Review)