Attention is currently required from: Eran Mitrani, Nick Vaccaro, Paul Menzel, Ravishankar Sarawadi, Sean Rhodes, Tarun.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78457?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: Revert "soc/intel/{tigerlake,meteorlake}: Check ITBT FW version"
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
Patchset:
PS7:
Done
I thought, Kapil tested this CL and verified S0ix was working
```
w/o test and broke MTL/TGL S0ix.
```
@Kapil, can you please comment on this ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78457?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib8eb11d36eac4e1c94a3349386442fa3eeeaef37
Gerrit-Change-Number: 78457
Gerrit-PatchSet: 9
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Mon, 30 Oct 2023 17:55:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Comment-In-Reply-To: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-MessageType: comment