Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36988 )
Change subject: mainboard/google: Fix Hatch baseboard/gpio.c default mux ......................................................................
mainboard/google: Fix Hatch baseboard/gpio.c default mux
The schematics seem to suggest F20,F21,F11,F22 are all NC.
BUG=b:144809606
Change-Id: Ide74ab6361f48f0e9c967b9e4318537f605bee2d Signed-off-by: Edward O'Callaghan quasisec@chromium.org --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/36988/1
diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index 598600b..d8625b9 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -301,12 +301,12 @@ PAD_NC(GPP_F18, NONE), /* F19 : GPP_F19 ==> NC */ PAD_NC(GPP_F19, NONE), - /* F20 : PCH_MEM_STRAP0 */ - PAD_CFG_GPI(GPP_F20, NONE, PLTRST), - /* F21 : PCH_MEM_STRAP1 */ - PAD_CFG_GPI(GPP_F21, NONE, PLTRST), - /* F22 : PCH_MEM_STRAP3 */ - PAD_CFG_GPI(GPP_F22, NONE, PLTRST), + /* F20 : GPP_F20 ==> NC */ + PAD_NC(GPP_F20, NONE), + /* F21 : GPP_F21 ==> NC */ + PAD_NC(GPP_F21, NONE), + /* F22 : GPP_F22 ==> NC */ + PAD_NC(GPP_F22, NONE), /* F23 : GPP_F23 ==> NC */ PAD_NC(GPP_F23, NONE),
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36988 )
Change subject: mainboard/google: Fix Hatch baseboard/gpio.c default mux ......................................................................
Patch Set 1:
Ed, as per discussion with Shelley, can you add default MEM_STRAPS here?
You can check default straps in mainboard/google/hatch/variants/helios/gpio.c and it's H19, H22, F10, F3.
Hello Edward O'Callaghan, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36988
to look at the new patch set (#2).
Change subject: mainboard/google: Fix Hatch baseboard/gpio.c default mux ......................................................................
mainboard/google: Fix Hatch baseboard/gpio.c default mux
The schematics seem to suggest F20,F21,F11,F22 are all NC.
BUG=b:144809606 BRANCH=hatch TEST=./util/abuild/abuild -p none -t google/hatch -x -a
Change-Id: Ide74ab6361f48f0e9c967b9e4318537f605bee2d Signed-off-by: Edward O'Callaghan quasisec@chromium.org --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/36988/2
Hello Edward O'Callaghan, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36988
to look at the new patch set (#3).
Change subject: mainboard/variant/hatch: Fix baseboard/gpio.c default mux ......................................................................
mainboard/variant/hatch: Fix baseboard/gpio.c default mux
The schematics seem to suggest F20,F21,F11,F22 are all NC.
BUG=b:144809606 BRANCH=hatch TEST=./util/abuild/abuild -p none -t google/hatch -x -a
Change-Id: Ide74ab6361f48f0e9c967b9e4318537f605bee2d Signed-off-by: Edward O'Callaghan quasisec@chromium.org --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/36988/3
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/36988?usp=email )
Change subject: mainboard/variant/hatch: Fix baseboard/gpio.c default mux ......................................................................
Abandoned
This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.
-
Edward O'Callaghan (Code Review) -
Kangheui Won (Code Review)
-
Martin L Roth (Code Review)