Attention is currently required from: Tim Crawford, Jeremy Soller, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56943 )
Change subject: soc/intel/tigerlake: Add TGL-H power limits
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/56943/comment/0ab39762_1ecc6f9e
PS2, Line 26: /* The first two are for TGL-U */
: #define POWER_LIMITS_U_2_CORE 0
: #define POWER_LIMITS_U_4_CORE 1
: #define POWER_LIMITS_Y_2_CORE 2
: #define POWER_LIMITS_Y_4_CORE 3
: #define POWER_LIMITS_H_6_CORE 4
: #define POWER_LIMITS_H_8_CORE 5
: #define POWER_LIMITS_MAX 6
Mind making this an enum now?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56943
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6fa7c7338b3157b29ff72769238597e3c528aedb
Gerrit-Change-Number: 56943
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 23 Aug 2021 01:56:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment