Attention is currently required from: Lee Leahy, Arthur Heymans. Hello Arthur Heymans,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/63065
to review the following change.
Change subject: drivers/intel/fsp1_1: Use C over CPP ......................................................................
drivers/intel/fsp1_1: Use C over CPP
This fixes building with clang.
Change-Id: Ida464d9ff96af3ff485682fbbf904bb2253ec44f Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/drivers/intel/fsp1_1/fsp_util.c 1 file changed, 19 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/63065/1
diff --git a/src/drivers/intel/fsp1_1/fsp_util.c b/src/drivers/intel/fsp1_1/fsp_util.c index 7dc16c3..1c205ae 100644 --- a/src/drivers/intel/fsp1_1/fsp_util.c +++ b/src/drivers/intel/fsp1_1/fsp_util.c @@ -89,26 +89,26 @@ (u8)((fsp_header->ImageRevision >> 16) & 0xff), (u8)((fsp_header->ImageRevision >> 8) & 0xff), (u8)(fsp_header->ImageRevision & 0xff)); -#if CONFIG(DISPLAY_FSP_ENTRY_POINTS) - printk(BIOS_SPEW, "FSP Entry Points:\n"); - printk(BIOS_SPEW, " %p: Image Base\n", fsp_base); - printk(BIOS_SPEW, " %p: TempRamInit\n", - &fsp_base[fsp_header->TempRamInitEntryOffset]); - printk(BIOS_SPEW, " %p: FspInit\n", - &fsp_base[fsp_header->FspInitEntryOffset]); - if (fsp_header->HeaderRevision >= FSP_HEADER_REVISION_2) { - printk(BIOS_SPEW, " %p: MemoryInit\n", - &fsp_base[fsp_header->FspMemoryInitEntryOffset]); - printk(BIOS_SPEW, " %p: TempRamExit\n", - &fsp_base[fsp_header->TempRamExitEntryOffset]); - printk(BIOS_SPEW, " %p: SiliconInit\n", - &fsp_base[fsp_header->FspSiliconInitEntryOffset]); + if (CONFIG(DISPLAY_FSP_ENTRY_POINTS)) { + printk(BIOS_SPEW, "FSP Entry Points:\n"); + printk(BIOS_SPEW, " %p: Image Base\n", fsp_base); + printk(BIOS_SPEW, " %p: TempRamInit\n", + &fsp_base[fsp_header->TempRamInitEntryOffset]); + printk(BIOS_SPEW, " %p: FspInit\n", + &fsp_base[fsp_header->FspInitEntryOffset]); + if (fsp_header->HeaderRevision >= FSP_HEADER_REVISION_2) { + printk(BIOS_SPEW, " %p: MemoryInit\n", + &fsp_base[fsp_header->FspMemoryInitEntryOffset]); + printk(BIOS_SPEW, " %p: TempRamExit\n", + &fsp_base[fsp_header->TempRamExitEntryOffset]); + printk(BIOS_SPEW, " %p: SiliconInit\n", + &fsp_base[fsp_header->FspSiliconInitEntryOffset]); + } + printk(BIOS_SPEW, " %p: NotifyPhase\n", + &fsp_base[fsp_header->NotifyPhaseEntryOffset]); + printk(BIOS_SPEW, " %p: Image End\n", + &fsp_base[fsp_header->ImageSize]); } - printk(BIOS_SPEW, " %p: NotifyPhase\n", - &fsp_base[fsp_header->NotifyPhaseEntryOffset]); - printk(BIOS_SPEW, " %p: Image End\n", - &fsp_base[fsp_header->ImageSize]); -#endif }
void fsp_notify(u32 phase)