Attention is currently required from: Damien Zammit, Angel Pons, Patrick Rudolph.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55413 )
Change subject: cpu,nb/intel: Drop remains of LAPIC_MONOTONIC_TIMER
......................................................................
Patch Set 9:
(2 comments)
File src/cpu/intel/model_1067x/model_1067x_init.c:
https://review.coreboot.org/c/coreboot/+/55413/comment/8ead0e55_59db0a27
PS1, Line 18: lapic_write(LAPIC_LVTT, (1 << 17) | (1 << 16) | (0 << 12) | (0 << 0));
For Intel CPUs, only model_1067x enters payload with LAPIC timer initialised. […]
Ack
File src/northbridge/intel/gm45/romstage.c:
https://review.coreboot.org/c/coreboot/+/55413/comment/ac7f1611_7272a289
PS1, Line 45: enable_lapic();
I'd explain in the commit message why these `enable_lapic()` calls are dropped. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55413
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I718050925f3eb32448fd08e76d259f0fb082d2d3
Gerrit-Change-Number: 55413
Gerrit-PatchSet: 9
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 05 Feb 2022 07:52:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment