28 Jun
2019
28 Jun
'19
2:44 p.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29970 )
Change subject: qcs405: Add RPM support ......................................................................
Patch Set 32:
(2 comments)
https://review.coreboot.org/#/c/29970/32/src/soc/qualcomm/qcs405/include/soc... File src/soc/qualcomm/qcs405/include/soc/symbols.h:
https://review.coreboot.org/#/c/29970/32/src/soc/qualcomm/qcs405/include/soc... PS32, Line 28: extern u8 _rpm[]; DECLARE_REGION(rpm)?
https://review.coreboot.org/#/c/29970/32/src/soc/qualcomm/qcs405/include/soc... PS32, Line 30: #define _rpm_size (_erpm - _rpm) replace with REGION_SIZE(rpm) at the use sites?
--
To view, visit https://review.coreboot.org/c/coreboot/+/29970
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17f491f0a4bd0dce7522b7e80e1bac97ec18b945
Gerrit-Change-Number: 29970
Gerrit-PatchSet: 32
Gerrit-Owner: Nitheesh Sekar nsekar@codeaurora.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nitheesh Sekar nsekar@codeaurora.org
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Sricharan Ramabadhran srichara@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Fri, 28 Jun 2019 12:44:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
1967
days inactive
1967
days old
0 comments
1 participants
participants (1)
-
Patrick Georgi (Code Review)