Attention is currently required from: Shuo Liu.
yuchi.chen@intel.com has posted comments on this change by yuchi.chen@intel.com. ( https://review.coreboot.org/c/coreboot/+/83314?usp=email )
Change subject: soc/intel/snowridge: add CPU and PCIe definitions for SNR
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83314/comment/711a0d21_4ab955be?usp... :
PS2, Line 8:
oops, please follow Felix's comment, but capitalize the 1st letter (add -> Add)
Should the first letter in the commit summary be capitalized? If so, I need to update all the commits.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83314?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3f5d612765bbe9adffe0b6c7a4151f32b33e88b4
Gerrit-Change-Number: 83314
Gerrit-PatchSet: 2
Gerrit-Owner: yuchi.chen@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Comment-Date: Thu, 04 Jul 2024 02:06:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shuo Liu
shuo.liu@intel.com