Attention is currently required from: Ravi kumar, Paul Menzel. Sudheer Amrabadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57449 )
Change subject: mb/google/herobrine: Add support for audio ......................................................................
Patch Set 34:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57449/comment/73061f8d_17f46b2f PS29, Line 7: Herobrine
mb/google/herobrine
Ack
https://review.coreboot.org/c/coreboot/+/57449/comment/033f4c3a_d9da2420 PS29, Line 7: Herobrine: sc7280: Add support for audio
… and TPM?
Ack
https://review.coreboot.org/c/coreboot/+/57449/comment/788c3fef_f4b2ce62 PS29, Line 7: sc7280:
Not needed.
Ack
https://review.coreboot.org/c/coreboot/+/57449/comment/c53451b7_3e05e270 PS29, Line 9: Add gpio configuration for target specific i2s ports
- Please add a dot/period at the end of the line. […]
Ack
Commit Message:
https://review.coreboot.org/c/coreboot/+/57449/comment/daac4ad0_d4bb614b PS32, Line 7: mb/google/herobrine :
Please remove the space.
Ack
Patchset:
PS34: updated related comments
File src/mainboard/google/herobrine/mainboard.c:
https://review.coreboot.org/c/coreboot/+/57449/comment/de11f550_d33e4495 PS28, Line 43:
No blank line needed.
Ack
-
Sudheer Amrabadi (Code Review)