[L] Change in coreboot[main]: mb/google/fatcat: Add minimal code support for fatcat - coreboot-gerrit

25 Jun 2024


      Attention is currently required from: Nick Vaccaro, YH Lin.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83197?usp=email )
Change subject: mb/google/fatcat: Add minimal code support for fatcat
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/fatcat/variants/fatcat/gpio.c:
https://review.coreboot.org/c/coreboot/+/83197/comment/5e08bee3_d7a8fbba?usp... :
PS5, Line 10: #include <boardid.h>
...
NIT - This should be between line 12 and 13 (i.e. above <soc/gpio. […]
Acknowledged
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83197?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iad78aec51b2f0f240991c9c35842764a60be988e
Gerrit-Change-Number: 83197
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: YH Lin yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: YH Lin yueherngl@google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Comment-Date: Tue, 25 Jun 2024 17:54:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro nvaccaro@google.com