Marc Jones has posted comments on this change. ( https://review.coreboot.org/28753 )
Change subject: soc/amd/stoneyridge: Add IOMMU support ......................................................................
Patch Set 1:
(2 comments)
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/28753/1/src/soc/amd/stoneyridge/iommu.c File src/soc/amd/stoneyridge/iommu.c:
https://review.coreboot.org/#/c/28753/1/src/soc/amd/stoneyridge/iommu.c@30 PS1, Line 30: 0x44
Any reason this value was chosen?
no, it is an arbitrary id for the resource. It is used by other iommu.c resource, so we should be consitent. *shrug*
https://review.coreboot.org/#/c/28753/1/src/soc/amd/stoneyridge/iommu.c@38 PS1, Line 38: static void iommu_set_resources(struct device *dev) : { : pci_dev_set_resources(dev); : }
Get rid of this and call pci_dev_set_resources directly from the ops table?
Done
-
Marc Jones (Code Review)