Attention is currently required from: Arthur Heymans, Felix Held, Krystian Hebel, Patrick Rudolph, Sergii Dmytruk.
Martin L Roth has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/83424?usp=email )
Change subject: drivers/smmstore: add ability to write to whole flash
......................................................................
Patch Set 5:
(1 comment)
File src/drivers/smmstore/store.c:
https://review.coreboot.org/c/coreboot/+/83424/comment/2e095796_02199a1a?usp... :
PS5, Line 49: if (*cmd & SMMSTORE_CMD_USE_FULL_FLASH) {
Can we add a check to make sure that we're actually doing a capsule update before enabling this inst […]
Oh, I guess I should have looked at the next commit in the patch train.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83424?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7f3dbfa965b9dcbade8b2f06a5bd2ac1345c7972
Gerrit-Change-Number: 83424
Gerrit-PatchSet: 5
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 30 Aug 2024 16:03:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com