Attention is currently required from: Daniil Lunev, Rizwan Qureshi.
Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62855 )
Change subject: soc/intel/common/block: Add Intel common UFS code support
......................................................................
Patch Set 2:
(2 comments)
File src/soc/intel/common/block/scs/ufs.c:
https://review.coreboot.org/c/coreboot/+/62855/comment/ea4876a4_61bf6791
PS1, Line 16: PCI_DEVICE_ID_INTEL_ADP_UFS
When building from tot it compains this should be PCI_DID_INTEL_ADP_UFS
Done
https://review.coreboot.org/c/coreboot/+/62855/comment/fe4874a8_3c48d5bb
PS1, Line 22: PCI_VENDOR_ID_INTEL
When building from tot it compains this should be PCI_VID_INTEL
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62855
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I92f034ced64e2eaef41a7807133361d74b5009d3
Gerrit-Change-Number: 62855
Gerrit-PatchSet: 2
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-CC: Daniil Lunev
dlunev@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Daniil Lunev
dlunev@chromium.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Comment-Date: Mon, 21 Mar 2022 05:47:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daniil Lunev
dlunev@chromium.org
Gerrit-MessageType: comment