Attention is currently required from: Paul Menzel, Tim Wawrzynczak.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58060 )
Change subject: src/ec/google/chromeec: Update google_chromeec_usb_pd_get_info()
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58060/comment/c87a61ff_74fbd4fd
PS1, Line 10: static and drop from ec.h
Please add a dot/period to the end of sentences. (Also other change-sets. […]
Done
File src/ec/google/chromeec/ec.h:
https://review.coreboot.org/c/coreboot/+/58060/comment/14960f83_6dd278fb
PS1, Line 36: /* Returns data role and type of device connected */
Please add the comment to the now static function.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58060
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b3df4223d5c26ea1c1a52b26f7d49fa4c947de8
Gerrit-Change-Number: 58060
Gerrit-PatchSet: 2
Gerrit-Owner: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 01 Oct 2021 09:59:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment