[S] Change in coreboot[main]: src/device: Add more condition to check valid PCI device id

[Subrata Banik (Code Review)]

Attention is currently required from: Anil Kumar K, Bora Guvendik, Jamie Ryu, Jeremy Compostella, Pratikkumar V Prajapati, Wonkyu Kim.

Subrata Banik has posted comments on this change by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/84228?usp=email )

Change subject: src/device: Add more condition to check valid PCI device id
......................................................................

Patch Set 2:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/84228/comment/f50a40fc_d47b7bca?usp... :
PS2, Line 12: Below are invalid PCI device id cases
            : VID: 0x0 or 0xffff
            : DID: 0x0 or 0xffff
> The change is not just WA but also avoiding coreboot's weird behavior.  The issue should be fixed by HW but I think coreboot should not stuck middle of execution without reporting error at least.

A invalid VID check itself is good enough IMO. I can't imagine a legit HW that has VID as 0 and DID as 0xffff. ideally VID itself has to be valid at first place to make the additional logic being probed.