Attention is currently required from: Tim Wawrzynczak, Rehan Ghori, Kenneth Chan.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60131 )
Change subject: mb/google/hatch/var/scout: improve USB2 port 4 strengh
......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60131/comment/b1e6afc9_fd31ee57
PS1, Line 7: strengh
strength
https://review.coreboot.org/c/coreboot/+/60131/comment/8545ebe3_42217d0f
PS1, Line 8:
What is the problem? What devices do not work?
https://review.coreboot.org/c/coreboot/+/60131/comment/85fe02fc_c2e1765a
PS1, Line 9: to 15mv
From what value? (What was it before?)
Why 15 mV? How did you determine that?
https://review.coreboot.org/c/coreboot/+/60131/comment/cdfaba17_585ff92e
PS1, Line 9: mv
mV
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60131
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8163b2be6c9094eaf08efc0325cf211235556dc8
Gerrit-Change-Number: 60131
Gerrit-PatchSet: 1
Gerrit-Owner: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Joe Tessler
jrt@google.com
Gerrit-Reviewer: Rehan Ghori
rehang@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Rehan Ghori
rehang@google.com
Gerrit-Attention: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 15 Dec 2021 17:09:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment