Attention is currently required from: Angel Pons, Arthur Heymans, Leah Rowe.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80717?usp=email )
Change subject: nb/haswell: Disable iGPU when dGPU is used
......................................................................
Patch Set 2:
(1 comment)
File src/northbridge/intel/haswell/gma.c:
https://review.coreboot.org/c/coreboot/+/80717/comment/5cbc26ce_834c1c8f :
PS2, Line 469: dev->enabled = 0;
Is this intentional or just copied from sandybridge? Is there a reason to mark this device as disabl […]
It looks odd indeed. I guess for the original i945 it made no difference,
but here (and in snb) we have things like power management to configure
(and resource allocation could be nice too).
It seems worth to test again with `dev->enabled` left untouched.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80717?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1df0a3aa42f8475b7741007bf3e28c2e089d916b
Gerrit-Change-Number: 80717
Gerrit-PatchSet: 2
Gerrit-Owner: Leah Rowe
leahleahrowerowe@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Leah Rowe
leahleahrowerowe@gmail.com
Gerrit-Comment-Date: Fri, 23 Feb 2024 21:17:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment