Attention is currently required from: Felix Singer, Nick Vaccaro.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79960?usp=email )
Change subject: intel tgl mainboards: Move PcieRpEnable option below dt entries ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/volteer/variants/voema/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79960/comment/1056b2fb_e89d7ae1 : PS1, Line 103: device ref pcie_rp7 off : register "PcieRpEnable[6]" = "0" : end
Right. The settings are mainly moved in order to make the review easier.
Acknowledged
https://review.coreboot.org/c/coreboot/+/79960/comment/c7069023_9cc6e248 : PS1, Line 108: probe DB_SD SD_GL9755S : probe DB_SD SD_RTS5261 : probe DB_SD SD_RTS5227S : probe DB_SD SD_GL9750 : probe DB_SD SD_OZ711LV2LN
Afaik it's only the same device for sconfig if it contains the exact same configuration as the one f […]
it shouldn't, especially when disabling a previously-enabled device. I'm not even sure it's valid as written