Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Karthik Ramasubramanian. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58114 )
Change subject: soc/amd/common/block/espi_util: Refactor ESPI Setup ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58114/comment/012f0fb0_e73d1dcc PS4, Line 7: ESPI eSPI. some more instances below.
File src/soc/amd/cezanne/early_fch.c:
https://review.coreboot.org/c/coreboot/+/58114/comment/f417320c_1346f6d2 PS4, Line 43: configure_espi(); see my comments on picasso's early_fch
File src/soc/amd/picasso/early_fch.c:
https://review.coreboot.org/c/coreboot/+/58114/comment/be4e7118_f539c39a PS4, Line 48: and SPI Fast speed overrides based on : board version. this isn't related to eSPI and also not what the code is doing
https://review.coreboot.org/c/coreboot/+/58114/comment/346e99f7_2fb6e8b1 PS4, Line 50: configure_espi(); lpc_early_init needs to be called before configure_espi, since lpc_early_init calls lpc_set_spibase to set up the SPI base that needs to be set up before calling for example espi_write32 in espi_setup that gets called be configure_espi. might be worth adding a comment on that here