Michael Niewöhner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
Add support for the X11SSM-F which is based on Intel KBL.
This change depends on I8dc4240ae042760a845e890b923ad40478bb8e29
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 --- M Documentation/mainboard/index.md A Documentation/mainboard/supermicro/x11/ssm-f/x11ssh-tf.md M src/mainboard/supermicro/x11/Kconfig A src/mainboard/supermicro/x11/mainboard.c M src/mainboard/supermicro/x11/ramstage.c A src/mainboard/supermicro/x11/variants/ssm-f/Kconfig A src/mainboard/supermicro/x11/variants/ssm-f/Kconfig.name A src/mainboard/supermicro/x11/variants/ssm-f/board_info.txt A src/mainboard/supermicro/x11/variants/ssm-f/devicetree.cb A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/acpidump.log A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/acpidump/apic.dat A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/acpidump/dmar.dat A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/acpidump/dsdt.dat A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/acpidump/facp.dat A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/acpidump/facs.dat A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/acpidump/hpet.dat A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/acpidump/mcfg.dat A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/acpidump/spmi.dat A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/acpidump/ssdt.dat A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/biosdecode.log A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/cpuinfo.log A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/dmesg.log A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/dmidecode.log A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/input_bustypes.log A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/intelmetool.log A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/inteltool.log A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/inteltool_gpio.log A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/inteltool_pcrs.txt A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/list_sys_proc.log A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/lshw.html A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/lshw.txt A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/lshw.xml A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/lspci.log A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/lsusb.log A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/msrtool.log A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/nvramtool.log A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/buddyinfo A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/cgroups A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/cmdline A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/config.gz A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/consoles A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/cpuinfo A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/crypto A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/devices A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/diskstats A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/execdomains A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/filesystems A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/interrupts A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/iomem A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/ioports A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/key-users A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/keys A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/loadavg A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/locks A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/mdstat A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/meminfo A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/misc A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/mtrr A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/pagetypeinfo A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/partitions A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/slabinfo A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/softirqs A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/stat A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/swaps A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/timer_list A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/uptime A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/version A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/vmallocinfo A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/vmstat A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/proc/zoneinfo A src/mainboard/supermicro/x11/variants/ssm-f/dumps/coreboot/superiotool.log A src/mainboard/supermicro/x11/variants/ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11/variants/ssm-f/ramstage.c A src/mainboard/supermicro/x11/variants/ssm-f/todo.txt A src/mainboard/supermicro/x11/variants/ssm-f/working_config 75 files changed, 88,362 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/1
Hello Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#2).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 --- M Documentation/mainboard/index.md A Documentation/mainboard/supermicro/x11/ssm-f/x11ssh-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/Kconfig A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/Kconfig.name A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/devicetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/log_dumps.tgz A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/todo.txt A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/working_config 14 files changed, 1,421 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 2:
(10 comments)
https://review.coreboot.org/c/coreboot/+/35427/2/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/2/src/mainboard/supermicro/x1... PS2, Line 27: int i; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/2/src/mainboard/supermicro/x1... PS2, Line 28: const uint16_t port = PID_ITSS; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/2/src/mainboard/supermicro/x1... PS2, Line 30: printk(BIOS_INFO, "ITSS IRQ Polarities BOOTBLOCK\n"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/2/src/mainboard/supermicro/x1... PS2, Line 31: for (i = 0; i < NUM_IPC_REGS; i++) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/2/src/mainboard/supermicro/x1... PS2, Line 31: for (i = 0; i < NUM_IPC_REGS; i++) { suspect code indent for conditional statements (3, 5)
https://review.coreboot.org/c/coreboot/+/35427/2/src/mainboard/supermicro/x1... PS2, Line 32: uint16_t reg = PCR_ITSS_IPC0_CONF + sizeof(uint32_t) * i; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/2/src/mainboard/supermicro/x1... PS2, Line 33: printk(BIOS_INFO, "IPC%d: 0x%08x\n", i, pcr_read32(port, reg)); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/2/src/mainboard/supermicro/x1... PS2, Line 34: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/2/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/ramstage.c:
https://review.coreboot.org/c/coreboot/+/35427/2/src/mainboard/supermicro/x1... PS2, Line 27: // TODO: on x11ssm FSP does not crash as in x11ssh; even when explicitely setting to 0x0 'explicitely' may be misspelled - perhaps 'explicitly'?
https://review.coreboot.org/c/coreboot/+/35427/2/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/todo.txt:
https://review.coreboot.org/c/coreboot/+/35427/2/src/mainboard/supermicro/x1... PS2, Line 13: - (TCO_BASE_LOCK): 1->0 (tco_lock() call in skylake mising) 'mising' may be misspelled - perhaps 'missing'?
Hello Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#3).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
current log dumps in log_dumps.tgz to make review easier
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 --- M Documentation/mainboard/index.md A Documentation/mainboard/supermicro/x11/ssm-f/x11ssh-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/Kconfig A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/Kconfig.name A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/devicetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/log_dumps.tgz A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/todo.txt A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/working_config 14 files changed, 1,421 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/3
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 4:
(10 comments)
https://review.coreboot.org/c/coreboot/+/35427/4/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/4/src/mainboard/supermicro/x1... PS4, Line 27: int i; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/4/src/mainboard/supermicro/x1... PS4, Line 28: const uint16_t port = PID_ITSS; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/4/src/mainboard/supermicro/x1... PS4, Line 30: printk(BIOS_INFO, "ITSS IRQ Polarities BOOTBLOCK\n"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/4/src/mainboard/supermicro/x1... PS4, Line 31: for (i = 0; i < NUM_IPC_REGS; i++) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/4/src/mainboard/supermicro/x1... PS4, Line 31: for (i = 0; i < NUM_IPC_REGS; i++) { suspect code indent for conditional statements (3, 5)
https://review.coreboot.org/c/coreboot/+/35427/4/src/mainboard/supermicro/x1... PS4, Line 32: uint16_t reg = PCR_ITSS_IPC0_CONF + sizeof(uint32_t) * i; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/4/src/mainboard/supermicro/x1... PS4, Line 33: printk(BIOS_INFO, "IPC%d: 0x%08x\n", i, pcr_read32(port, reg)); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/4/src/mainboard/supermicro/x1... PS4, Line 34: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/4/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/ramstage.c:
https://review.coreboot.org/c/coreboot/+/35427/4/src/mainboard/supermicro/x1... PS4, Line 27: // TODO: on x11ssm FSP does not crash as in x11ssh; even when explicitely setting to 0x0 'explicitely' may be misspelled - perhaps 'explicitly'?
https://review.coreboot.org/c/coreboot/+/35427/4/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/todo.txt:
https://review.coreboot.org/c/coreboot/+/35427/4/src/mainboard/supermicro/x1... PS4, Line 13: - (TCO_BASE_LOCK): 1->0 (tco_lock() call in skylake mising) 'mising' may be misspelled - perhaps 'missing'?
Hello Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#5).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
current log dumps in log_dumps.tgz to make review easier
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 --- M Documentation/mainboard/index.md A Documentation/mainboard/supermicro/x11/ssm-f/x11ssh-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/Kconfig A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/Kconfig.name A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/devicetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/log_dumps.tgz A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/todo.txt A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/working_config 14 files changed, 1,421 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/5
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 5:
(10 comments)
https://review.coreboot.org/c/coreboot/+/35427/5/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/5/src/mainboard/supermicro/x1... PS5, Line 27: int i; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/5/src/mainboard/supermicro/x1... PS5, Line 28: const uint16_t port = PID_ITSS; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/5/src/mainboard/supermicro/x1... PS5, Line 30: printk(BIOS_INFO, "ITSS IRQ Polarities BOOTBLOCK\n"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/5/src/mainboard/supermicro/x1... PS5, Line 31: for (i = 0; i < NUM_IPC_REGS; i++) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/5/src/mainboard/supermicro/x1... PS5, Line 31: for (i = 0; i < NUM_IPC_REGS; i++) { suspect code indent for conditional statements (3, 5)
https://review.coreboot.org/c/coreboot/+/35427/5/src/mainboard/supermicro/x1... PS5, Line 32: uint16_t reg = PCR_ITSS_IPC0_CONF + sizeof(uint32_t) * i; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/5/src/mainboard/supermicro/x1... PS5, Line 33: printk(BIOS_INFO, "IPC%d: 0x%08x\n", i, pcr_read32(port, reg)); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/5/src/mainboard/supermicro/x1... PS5, Line 34: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/5/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/ramstage.c:
https://review.coreboot.org/c/coreboot/+/35427/5/src/mainboard/supermicro/x1... PS5, Line 27: // TODO: on x11ssm FSP does not crash as in x11ssh; even when explicitely setting to 0x0 'explicitely' may be misspelled - perhaps 'explicitly'?
https://review.coreboot.org/c/coreboot/+/35427/5/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/todo.txt:
https://review.coreboot.org/c/coreboot/+/35427/5/src/mainboard/supermicro/x1... PS5, Line 13: - (TCO_BASE_LOCK): 1->0 (tco_lock() call in skylake mising) 'mising' may be misspelled - perhaps 'missing'?
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 6:
(10 comments)
https://review.coreboot.org/c/coreboot/+/35427/6/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/6/src/mainboard/supermicro/x1... PS6, Line 27: int i; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/6/src/mainboard/supermicro/x1... PS6, Line 28: const uint16_t port = PID_ITSS; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/6/src/mainboard/supermicro/x1... PS6, Line 30: printk(BIOS_INFO, "ITSS IRQ Polarities BOOTBLOCK\n"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/6/src/mainboard/supermicro/x1... PS6, Line 31: for (i = 0; i < NUM_IPC_REGS; i++) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/6/src/mainboard/supermicro/x1... PS6, Line 31: for (i = 0; i < NUM_IPC_REGS; i++) { suspect code indent for conditional statements (3, 5)
https://review.coreboot.org/c/coreboot/+/35427/6/src/mainboard/supermicro/x1... PS6, Line 32: uint16_t reg = PCR_ITSS_IPC0_CONF + sizeof(uint32_t) * i; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/6/src/mainboard/supermicro/x1... PS6, Line 33: printk(BIOS_INFO, "IPC%d: 0x%08x\n", i, pcr_read32(port, reg)); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/6/src/mainboard/supermicro/x1... PS6, Line 34: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/6/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/ramstage.c:
https://review.coreboot.org/c/coreboot/+/35427/6/src/mainboard/supermicro/x1... PS6, Line 27: // TODO: on x11ssm FSP does not crash as in x11ssh; even when explicitely setting to 0x0 'explicitely' may be misspelled - perhaps 'explicitly'?
https://review.coreboot.org/c/coreboot/+/35427/6/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/todo.txt:
https://review.coreboot.org/c/coreboot/+/35427/6/src/mainboard/supermicro/x1... PS6, Line 13: - (TCO_BASE_LOCK): 1->0 (tco_lock() call in skylake mising) 'mising' may be misspelled - perhaps 'missing'?
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 7:
(10 comments)
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... PS7, Line 27: int i; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... PS7, Line 28: const uint16_t port = PID_ITSS; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... PS7, Line 30: printk(BIOS_INFO, "ITSS IRQ Polarities BOOTBLOCK\n"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... PS7, Line 31: for (i = 0; i < NUM_IPC_REGS; i++) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... PS7, Line 31: for (i = 0; i < NUM_IPC_REGS; i++) { suspect code indent for conditional statements (3, 5)
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... PS7, Line 32: uint16_t reg = PCR_ITSS_IPC0_CONF + sizeof(uint32_t) * i; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... PS7, Line 33: printk(BIOS_INFO, "IPC%d: 0x%08x\n", i, pcr_read32(port, reg)); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... PS7, Line 34: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/ramstage.c:
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... PS7, Line 27: // TODO: on x11ssm FSP does not crash as in x11ssh; even when explicitely setting to 0x0 'explicitely' may be misspelled - perhaps 'explicitly'?
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/todo.txt:
https://review.coreboot.org/c/coreboot/+/35427/7/src/mainboard/supermicro/x1... PS7, Line 13: - (TCO_BASE_LOCK): 1->0 (tco_lock() call in skylake mising) 'mising' may be misspelled - perhaps 'missing'?
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 8:
(10 comments)
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... PS8, Line 27: int i; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... PS8, Line 28: const uint16_t port = PID_ITSS; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... PS8, Line 30: printk(BIOS_INFO, "ITSS IRQ Polarities BOOTBLOCK\n"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... PS8, Line 31: for (i = 0; i < NUM_IPC_REGS; i++) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... PS8, Line 31: for (i = 0; i < NUM_IPC_REGS; i++) { suspect code indent for conditional statements (3, 5)
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... PS8, Line 32: uint16_t reg = PCR_ITSS_IPC0_CONF + sizeof(uint32_t) * i; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... PS8, Line 33: printk(BIOS_INFO, "IPC%d: 0x%08x\n", i, pcr_read32(port, reg)); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... PS8, Line 34: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/ramstage.c:
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... PS8, Line 27: // TODO: on x11ssm FSP does not crash as in x11ssh; even when explicitely setting to 0x0 'explicitely' may be misspelled - perhaps 'explicitly'?
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/todo.txt:
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... PS8, Line 13: - (TCO_BASE_LOCK): 1->0 (tco_lock() call in skylake mising) 'mising' may be misspelled - perhaps 'missing'?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 8:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35427/8/Documentation/mainboard/sup... File Documentation/mainboard/supermicro/x11/ssm-f/x11ssh-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/8/Documentation/mainboard/sup... PS8, Line 12: [Intel FSP2.0] can not be removed as long as there is no free replacement This is basically "FSP 2.0 can't bre removed because nobody bothered to write a replacement"
https://review.coreboot.org/c/coreboot/+/35427/8/Documentation/mainboard/sup... PS8, Line 39: to fail. This fits on the previous line (if the .md files also have a 96-char line length limit)
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/Kconfig:
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... PS8, Line 5: ssm-f I would use the full name: x11ssm-f
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... PS8, Line 20: # defaults to 0; datasheet says clkreq# isn't supported for root ports and this is RO; can we drop this then? I guess. At least remove these long comments please :D
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/todo.txt:
PS8: Move to documentation?
Hello Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#9).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
This adds another x11 series board, the X11SSM-F.
current log dumps in log_dumps.tgz to make review easier
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/ssm-f/x11ssh-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/Kconfig A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/log_dumps.tgz A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/overridetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/todo.txt A src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/working_config 14 files changed, 1,421 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/9
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 9:
(10 comments)
https://review.coreboot.org/c/coreboot/+/35427/9/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/9/src/mainboard/supermicro/x1... PS9, Line 27: int i; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/9/src/mainboard/supermicro/x1... PS9, Line 28: const uint16_t port = PID_ITSS; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/9/src/mainboard/supermicro/x1... PS9, Line 30: printk(BIOS_INFO, "ITSS IRQ Polarities BOOTBLOCK\n"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/9/src/mainboard/supermicro/x1... PS9, Line 31: for (i = 0; i < NUM_IPC_REGS; i++) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/9/src/mainboard/supermicro/x1... PS9, Line 31: for (i = 0; i < NUM_IPC_REGS; i++) { suspect code indent for conditional statements (3, 5)
https://review.coreboot.org/c/coreboot/+/35427/9/src/mainboard/supermicro/x1... PS9, Line 32: uint16_t reg = PCR_ITSS_IPC0_CONF + sizeof(uint32_t) * i; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/9/src/mainboard/supermicro/x1... PS9, Line 33: printk(BIOS_INFO, "IPC%d: 0x%08x\n", i, pcr_read32(port, reg)); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/9/src/mainboard/supermicro/x1... PS9, Line 34: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/9/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/ramstage.c:
https://review.coreboot.org/c/coreboot/+/35427/9/src/mainboard/supermicro/x1... PS9, Line 27: // TODO: on x11ssm FSP does not crash as in x11ssh; even when explicitely setting to 0x0 'explicitely' may be misspelled - perhaps 'explicitly'?
https://review.coreboot.org/c/coreboot/+/35427/9/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/todo.txt:
https://review.coreboot.org/c/coreboot/+/35427/9/src/mainboard/supermicro/x1... PS9, Line 13: - (TCO_BASE_LOCK): 1->0 (tco_lock() call in skylake mising) 'mising' may be misspelled - perhaps 'missing'?
Hello Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#10).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
This adds another x11 series board, the X11SSM-F.
current log dumps in log_dumps.tgz to make review easier
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/log_dumps.tgz A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssh-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Kconfig A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/todo.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config 14 files changed, 1,440 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/10
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 10:
(10 comments)
https://review.coreboot.org/c/coreboot/+/35427/10/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/10/src/mainboard/supermicro/x... PS10, Line 27: int i; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/10/src/mainboard/supermicro/x... PS10, Line 28: const uint16_t port = PID_ITSS; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/10/src/mainboard/supermicro/x... PS10, Line 30: printk(BIOS_INFO, "ITSS IRQ Polarities BOOTBLOCK\n"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/10/src/mainboard/supermicro/x... PS10, Line 31: for (i = 0; i < NUM_IPC_REGS; i++) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/10/src/mainboard/supermicro/x... PS10, Line 31: for (i = 0; i < NUM_IPC_REGS; i++) { suspect code indent for conditional statements (3, 5)
https://review.coreboot.org/c/coreboot/+/35427/10/src/mainboard/supermicro/x... PS10, Line 32: uint16_t reg = PCR_ITSS_IPC0_CONF + sizeof(uint32_t) * i; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/10/src/mainboard/supermicro/x... PS10, Line 33: printk(BIOS_INFO, "IPC%d: 0x%08x\n", i, pcr_read32(port, reg)); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/10/src/mainboard/supermicro/x... PS10, Line 34: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/10/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/ramstage.c:
https://review.coreboot.org/c/coreboot/+/35427/10/src/mainboard/supermicro/x... PS10, Line 27: // TODO: on x11ssm FSP does not crash as in x11ssh; even when explicitely setting to 0x0 'explicitely' may be misspelled - perhaps 'explicitly'?
https://review.coreboot.org/c/coreboot/+/35427/10/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/todo.txt:
https://review.coreboot.org/c/coreboot/+/35427/10/src/mainboard/supermicro/x... PS10, Line 13: - (TCO_BASE_LOCK): 1->0 (tco_lock() call in skylake mising) 'mising' may be misspelled - perhaps 'missing'?
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 10:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35427/8/Documentation/mainboard/sup... File Documentation/mainboard/supermicro/x11/ssm-f/x11ssh-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/8/Documentation/mainboard/sup... PS8, Line 39: to fail.
This fits on the previous line (if the . […]
Done
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/Kconfig:
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... PS8, Line 5: ssm-f
I would use the full name: x11ssm-f
Done
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... PS8, Line 20: # defaults to 0; datasheet says clkreq# isn't supported for root ports and this is RO; can we drop this then?
I guess. […]
I don't want them to get merged; this is just a hint for review; this will get removed as soon as I am sure this can be removed
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/todo.txt:
PS8:
Move to documentation?
Done
Hello Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#11).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
This adds another x11 series board, the X11SSM-F.
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/log_dumps.tgz A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssh-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Kconfig A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/todo.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config 14 files changed, 1,440 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/11
Hello Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#12).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
This adds another x11 series board, the X11SSM-F.
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/log_dumps.tgz A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssh-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Kconfig A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/todo.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config 14 files changed, 1,439 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/12
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 12:
(10 comments)
https://review.coreboot.org/c/coreboot/+/35427/12/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/12/src/mainboard/supermicro/x... PS12, Line 27: int i; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/12/src/mainboard/supermicro/x... PS12, Line 28: const uint16_t port = PID_ITSS; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/12/src/mainboard/supermicro/x... PS12, Line 30: printk(BIOS_INFO, "ITSS IRQ Polarities BOOTBLOCK\n"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/12/src/mainboard/supermicro/x... PS12, Line 31: for (i = 0; i < NUM_IPC_REGS; i++) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/12/src/mainboard/supermicro/x... PS12, Line 31: for (i = 0; i < NUM_IPC_REGS; i++) { suspect code indent for conditional statements (3, 5)
https://review.coreboot.org/c/coreboot/+/35427/12/src/mainboard/supermicro/x... PS12, Line 32: uint16_t reg = PCR_ITSS_IPC0_CONF + sizeof(uint32_t) * i; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/12/src/mainboard/supermicro/x... PS12, Line 33: printk(BIOS_INFO, "IPC%d: 0x%08x\n", i, pcr_read32(port, reg)); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/12/src/mainboard/supermicro/x... PS12, Line 34: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35427/12/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/ramstage.c:
https://review.coreboot.org/c/coreboot/+/35427/12/src/mainboard/supermicro/x... PS12, Line 27: // TODO: on x11ssm FSP does not crash as in x11ssh; even when explicitely setting to 0x0 'explicitely' may be misspelled - perhaps 'explicitly'?
https://review.coreboot.org/c/coreboot/+/35427/12/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/todo.txt:
https://review.coreboot.org/c/coreboot/+/35427/12/src/mainboard/supermicro/x... PS12, Line 13: - (TCO_BASE_LOCK): 1->0 (tco_lock() call in skylake mising) 'mising' may be misspelled - perhaps 'missing'?
Hello Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#13).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
This adds another x11 series board, the X11SSM-F.
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/log_dumps.tgz A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssh-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Kconfig A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config 12 files changed, 1,389 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/13
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 13: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/35427/13/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssh-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/13/Documentation/mainboard/su... PS13, Line 38: - After S5 resume coreboot detects more DIMMs than installed, causing FSP-M to fail. that's already fixed on SSH-TF
https://review.coreboot.org/c/coreboot/+/35427/13/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Kconfig:
https://review.coreboot.org/c/coreboot/+/35427/13/src/mainboard/supermicro/x... PS13, Line 3: config VARIANT_DIR should be part of the baseboard Kconfig
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#14).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
This adds another x11 series board, the X11SSM-F.
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/log_dumps.tgz A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssh-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Kconfig A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config 11 files changed, 1,389 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/14
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 14:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35427/13/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssh-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/13/Documentation/mainboard/su... PS13, Line 38: - After S5 resume coreboot detects more DIMMs than installed, causing FSP-M to fail.
that's already fixed on SSH-TF
according to Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-f/x11ssh-tf.md it isn't
https://review.coreboot.org/c/coreboot/+/35427/8/Documentation/mainboard/sup... File Documentation/mainboard/supermicro/x11/ssm-f/x11ssh-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/8/Documentation/mainboard/sup... PS8, Line 12: [Intel FSP2.0] can not be removed as long as there is no free replacement
This is basically "FSP 2. […]
both say actually the same...
https://review.coreboot.org/c/coreboot/+/35427/13/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Kconfig:
https://review.coreboot.org/c/coreboot/+/35427/13/src/mainboard/supermicro/x... PS13, Line 3: config VARIANT_DIR
should be part of the baseboard Kconfig
why? it's only needed when x11ssm is selected
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#15).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
This adds another x11 series board, the X11SSM-F.
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/log_dumps.tgz A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Kconfig A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config 11 files changed, 1,388 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/15
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#16).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
This adds another x11 series board, the X11SSM-F.
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/log_dumps.tgz A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Kconfig A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config 11 files changed, 1,388 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/16
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 17:
(3 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/35427/13/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssh-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/13/Documentation/mainboard/su... PS13, Line 38: - After S5 resume coreboot detects more DIMMs than installed, causing FSP-M to fail.
according to Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-f/x11ssh-tf. […]
Done
https://review.coreboot.org/c/coreboot/+/35427/8/Documentation/mainboard/sup... File Documentation/mainboard/supermicro/x11/ssm-f/x11ssh-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/8/Documentation/mainboard/sup... PS8, Line 12: [Intel FSP2.0] can not be removed as long as there is no free replacement
both say actually the same...
Done
https://review.coreboot.org/c/coreboot/+/35427/13/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Kconfig:
https://review.coreboot.org/c/coreboot/+/35427/13/src/mainboard/supermicro/x... PS13, Line 3: config VARIANT_DIR
why? it's only needed when x11ssm is selected
Done
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 17: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/35427/17/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/35427/17/src/mainboard/supermicro/x... PS17, Line 22: #define X11SSM_F_PAD_DW0_DW1_CFG(val, config0, config1) \ why does this define exists?
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#18).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
This adds another x11 series board, the X11SSM-F.
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/log_dumps.tgz A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config 11 files changed, 1,376 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/18
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 17:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35427/17/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/35427/17/src/mainboard/supermicro/x... PS17, Line 22: #define X11SSM_F_PAD_DW0_DW1_CFG(val, config0, config1) \
why does this define exists?
I copied that from somewhere... but it' not really needed. removed
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#19).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
This adds another x11 series board, the X11SSM-F.
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/log_dumps.tgz A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config 11 files changed, 1,380 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/19
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#20).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
This adds another x11 series board, the X11SSM-F.
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/log_dumps.tgz A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config 11 files changed, 1,378 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/20
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#21).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
This adds another x11 series board, the X11SSM-F.
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/log_dumps.tgz A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config 11 files changed, 1,371 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/21
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#22).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
This adds another x11 series board, the X11SSM-F.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/log_dumps.tgz A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config 11 files changed, 1,369 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/22
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#23).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
This adds another x11 series board, the X11SSM-F.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/log_dumps.tgz A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config 11 files changed, 1,345 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/23
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#24).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
This adds another x11 series board, the X11SSM-F.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/log_dumps.tgz A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config 11 files changed, 1,345 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/24
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 24:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/ssm-f/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35427/8/src/mainboard/supermicro/x1... PS8, Line 20: # defaults to 0; datasheet says clkreq# isn't supported for root ports and this is RO; can we drop this then?
I don't want them to get merged; this is just a hint for review; this will get removed as soon as I […]
Done
https://review.coreboot.org/c/coreboot/+/35427/17/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/35427/17/src/mainboard/supermicro/x... PS17, Line 22: #define X11SSM_F_PAD_DW0_DW1_CFG(val, config0, config1) \
I copied that from somewhere... but it' not really needed. […]
Done
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 25:
(6 comments)
Is doc/log_dumps.tgz intentional, not linked anywhere?
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... PS25, Line 3: select BOARD_SUPERMICRO_BASEBOARD_X11 Might not be compulsory, but I would prefer if the last part matched the directory name here.
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... PS25, Line 4: config BOARD_SUPERMICRO_X11SSM_F Typically there is an empty line before keyword config. Sometimes the variant name displayed in menuconfig has '-> ' in front.
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... PS25, Line 27: if (CONFIG(BOARD_SUPERMICRO_X11SSM_F)) { If you ask me, these should be forbidden in the base directory, once you apply variants-directory scheme. Others are likely to accept this, even though we know it gets ugly fast after a couple variant boards.
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/ramstage.c:
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... PS25, Line 25: // probably can be removed here So this code is also variant-dependent?
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... PS25, Line 22: #ifndef __ACPI__ Why? This file does not provide anything usable for .asl?
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config:
PS25: We have configs/ directory, maybe better choice would be to commit the result of 'make savedefconfig' there after code merge, if necessary. Typically we would like the default config to be bootable. A full config file like this becomes stale as soon as some of these Kconfig variables is removed or renamed, and that happens quite often.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 25:
(6 comments)
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... PS25, Line 3: select BOARD_SUPERMICRO_BASEBOARD_X11
Might not be compulsory, but I would prefer if the last part matched the directory name here.
Done
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... PS25, Line 4: config BOARD_SUPERMICRO_X11SSM_F
Typically there is an empty line before keyword config. […]
Done
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... PS25, Line 27: if (CONFIG(BOARD_SUPERMICRO_X11SSM_F)) {
If you ask me, these should be forbidden in the base directory, once you apply variants-directory sc […]
How should this be done, then? (I wanted to move as many stuff as possible to the variants dir but many people complained about it....)
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/ramstage.c:
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... PS25, Line 25: // probably can be removed here
So this code is also variant-dependent?
Seems so, yes; x11ssh crashes, x11ssm does not
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... PS25, Line 22: #ifndef __ACPI__
Why? This file does not provide anything usable for . […]
This was copied from x11ssh. I have no clue. See src/mainboard/intel/kblrvp/variants/rvp11/include/variant/gpio.h
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config:
PS25:
We have configs/ directory, maybe better choice would be to commit the result of 'make savedefconfig […]
as the board isn't complete yet, I wanted to have a complete, fully working config somewhere (to make testing for others easier). As soon as all problems are resolved, I aggree that this should be removed/moved.
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#26).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
This adds another x11 series board, the X11SSM-F.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/log_dumps.tgz A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config 11 files changed, 1,346 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/26
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 26:
Patch Set 25:
(6 comments)
Is doc/log_dumps.tgz intentional, not linked anywhere?
yes
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 26:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35427/26//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35427/26//COMMIT_MSG@10 PS26, Line 10: Please add a short summary, what is different from the other board? (Maybe somehow integrate this in `Documentation` and reference this here.)
https://review.coreboot.org/c/coreboot/+/35427/26/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/26/Documentation/mainboard/su... PS26, Line 37: Tianocore TianoCore
https://review.coreboot.org/c/coreboot/+/35427/26/Documentation/mainboard/su... PS26, Line 64: SATA S-ATA ports?
https://review.coreboot.org/c/coreboot/+/35427/26/Documentation/mainboard/su... PS26, Line 66: - Super I/O initialisation Needed?
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#27).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
This adds another x11 series board, the X11SSM-F.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/log_dumps.tgz A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config 11 files changed, 1,346 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/27
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 27:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35427/26/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/26/Documentation/mainboard/su... PS26, Line 66: - Super I/O initialisation
Needed?
?? this is mostly copied from x11ssh-tf
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 27:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35427/26//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35427/26//COMMIT_MSG@10 PS26, Line 10:
Please add a short summary, what is different from the other board? (Maybe somehow integrate this in […]
not sure if this is really necessary; one can look up on the vendors site
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 27:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35427/26//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35427/26//COMMIT_MSG@10 PS26, Line 10:
not sure if this is really necessary; one can look up on the vendors site
will be done in a follow up CR that reworks both documentation (already actively working on it)
https://review.coreboot.org/c/coreboot/+/35427/26/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/26/Documentation/mainboard/su... PS26, Line 37: Tianocore
TianoCore
will be done in a follow up CR that reworks both documentation (already actively working on it)
https://review.coreboot.org/c/coreboot/+/35427/26/Documentation/mainboard/su... PS26, Line 64: SATA
S-ATA ports?
see above
https://review.coreboot.org/c/coreboot/+/35427/26/Documentation/mainboard/su... PS26, Line 66: - Super I/O initialisation
?? this is mostly copied from x11ssh-tf
Done
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/ramstage.c:
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... PS25, Line 25: // probably can be removed here
Seems so, yes; x11ssh crashes, x11ssm does not
Done
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#28).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
This adds another x11 series board, the X11SSM-F.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/log_dumps.tgz A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name M src/mainboard/supermicro/x11-lga1151-series/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config 13 files changed, 1,371 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/28
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 28:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... PS25, Line 27: if (CONFIG(BOARD_SUPERMICRO_X11SSM_F)) {
How should this be done, then? (I wanted to move as many stuff as possible to the variants dir but m […]
done
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#29).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
This adds another x11 series board, the X11SSM-F.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/log_dumps.tgz A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name M src/mainboard/supermicro/x11-lga1151-series/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config 13 files changed, 1,369 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/29
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 30:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35427/30//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35427/30//COMMIT_MSG@10 PS30, Line 10: Please add what was tested. (Or refer to the documentation.)
Also, a small comment, why – despite the same baseboard – there can’t be one image that supports the same series (from the baseboard) would be appreciated.
https://review.coreboot.org/c/coreboot/+/35427/30/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/30/Documentation/mainboard/su... PS30, Line 37: Tianocore TianoCore
https://review.coreboot.org/c/coreboot/+/35427/30/Documentation/mainboard/su... PS30, Line 60: ## Tested and working What payload and OS version?
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#31).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
This adds another x11 series board, the X11SSM-F.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/log_dumps.tgz A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name M src/mainboard/supermicro/x11-lga1151-series/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config 15 files changed, 1,392 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/31
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#32).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
This adds another x11 series board, the X11SSM-F.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/log_dumps.tgz A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name M src/mainboard/supermicro/x11-lga1151-series/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config 15 files changed, 1,392 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/32
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#33).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
This adds another x11 series board, the X11SSM-F.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/log_dumps.tgz A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name M src/mainboard/supermicro/x11-lga1151-series/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config 15 files changed, 1,392 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/33
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#34).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
This adds another x11 series board, the X11SSM-F.
For details and differences check the documentation, that gets reworked in CB:35547.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/log_dumps.tgz A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name M src/mainboard/supermicro/x11-lga1151-series/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config 15 files changed, 1,392 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/34
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 34:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35427/30//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35427/30//COMMIT_MSG@10 PS30, Line 10:
Please add what was tested. (Or refer to the documentation.)
mentioned documentation
there can’t be one image that supports the same series (from the baseboard) would be appreciated
That should be obvious (think of GPIO etc.) but I added a short statement
https://review.coreboot.org/c/coreboot/+/35427/30/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/30/Documentation/mainboard/su... PS30, Line 37: Tianocore
TianoCore
done in CB:35547
https://review.coreboot.org/c/coreboot/+/35427/30/Documentation/mainboard/su... PS30, Line 60: ## Tested and working
What payload and OS version?
Done
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... PS25, Line 22: #ifndef __ACPI__
This was copied from x11ssh. I have no clue. […]
removed; done
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#35).
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
mb/supermicro/x11: add x11ssm-f board
This adds another x11 series board, the X11SSM-F, which is similiar to X11SSH-TF but differs in PCIe interfaces/devices, GPIO settings and Ethernet interfaces.
For details and differences check the documentation, that gets reworked in CB:35547.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/log_dumps.tgz A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name M src/mainboard/supermicro/x11-lga1151-series/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/working_config 15 files changed, 1,392 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/35
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 35: Code-Review+1
(2 comments)
we don't accept .tgz or "working" configs, just source code. With that fixed it's ready to be merged.
https://review.coreboot.org/c/coreboot/+/35427/35/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35427/35/src/mainboard/supermicro/x... PS35, Line 21: CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/include not required
https://review.coreboot.org/c/coreboot/+/35427/35/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/35/src/mainboard/supermicro/x... PS35, Line 18: #include <mainboard.h> include/mainboard.h
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 35: Code-Review+1
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 35:
Patch Set 35: Code-Review+1
(2 comments)
we don't accept .tgz or "working" configs, just source code. With that fixed it's ready to be merged.
config file will be removed; shall I remove the logs completely or add them as plain files?
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#36).
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
mb/supermicro/x11-lga1151-series: add x11ssm-f board
This adds another x11 series board, the X11SSM-F, which is similiar to X11SSH-TF but differs in PCIe interfaces/devices, GPIO settings and Ethernet interfaces.
For details and differences check the documentation, that gets reworked in CB:35547.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name A src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb 12 files changed, 582 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/36
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Patch Set 36: Code-Review+2
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#37).
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
mb/supermicro/x11-lga1151-series: add x11ssm-f board
This adds another x11 series board, the X11SSM-F, which is similiar to X11SSH-TF but differs in PCIe interfaces/devices, GPIO settings and Ethernet interfaces.
For details and differences check the documentation, that gets reworked in CB:35547.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name M src/mainboard/supermicro/x11-lga1151-series/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb 13 files changed, 584 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/37
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Patch Set 37:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35427/35/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35427/35/src/mainboard/supermicro/x... PS35, Line 21: CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/include
not required
is definitely required as neither $(src)/mainboard/$(MAINBOARDDIR) nor $(src)/mainboard/$(MAINBOARDDIR)/include are added per default; compare src/mainboard/intel/harcuvar/Makefile.inc, src/mainboard/emulation/qemu-aarch64/Makefile.inc, src/mainboard/emulation/qemu-riscv/Makefile.inc and some others.
Build fails without this
https://review.coreboot.org/c/coreboot/+/35427/35/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/35/src/mainboard/supermicro/x... PS35, Line 18: #include <mainboard.h>
include/mainboard. […]
Done
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Patch Set 37: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/35427/37/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/37/Documentation/mainboard/su... PS37, Line 43: - Error no CMOS option 'power_on_after_fail' that's fixed
https://review.coreboot.org/c/coreboot/+/35427/37/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35427/37/src/mainboard/supermicro/x... PS37, Line 48: chip drivers/ipmi nit: why is that not in devicetree.cb?
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#38).
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
mb/supermicro/x11-lga1151-series: add x11ssm-f board
This adds another x11 series board, the X11SSM-F, which is similiar to X11SSH-TF but differs in PCIe interfaces/devices, GPIO settings and Ethernet interfaces.
The Documentation gets split into a generic and board specific sections in CB:35547.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name M src/mainboard/supermicro/x11-lga1151-series/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb 13 files changed, 585 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/38
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Patch Set 38:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35427/37/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/37/Documentation/mainboard/su... PS37, Line 43: - Error no CMOS option 'power_on_after_fail'
that's fixed
Done
https://review.coreboot.org/c/coreboot/+/35427/37/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35427/37/src/mainboard/supermicro/x... PS37, Line 48: chip drivers/ipmi
nit: why is that not in devicetree. […]
because not every X11 series board has IPMI; currently we could move this to devicetree but as soon as another board get's added, we need to move it again
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Patch Set 38:
I have merged the board specific section CB:35547
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#39).
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
mb/supermicro/x11-lga1151-series: add x11ssm-f board
This adds another x11 series board, the X11SSM-F, which is similiar to X11SSH-TF but differs in PCIe interfaces/devices, GPIO settings and Ethernet interfaces.
The Documentation gets split into a generic and board specific sections in CB:35547.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/supermicro/x11-lga1151-series/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name M src/mainboard/supermicro/x11-lga1151-series/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h A src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/ramstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb 13 files changed, 584 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/39
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#40).
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
mb/supermicro/x11-lga1151-series: add x11ssm-f board
This adds another x11 series board, the X11SSM-F, which is similiar to X11SSH-TF but differs in PCIe interfaces/devices, GPIO settings and Ethernet interfaces.
The Documentation gets split into a generic and board specific sections in CB:35547.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name M src/mainboard/supermicro/x11-lga1151-series/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h A src/mainboard/supermicro/x11-lga1151-series/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb 11 files changed, 581 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/40
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#41).
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
mb/supermicro/x11-lga1151-series: add x11ssm-f board
This adds another x11 series board, the X11SSM-F, which is similiar to X11SSH-TF but differs in PCIe interfaces/devices, GPIO settings and Ethernet interfaces.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name M src/mainboard/supermicro/x11-lga1151-series/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h A src/mainboard/supermicro/x11-lga1151-series/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb 11 files changed, 581 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/41
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Patch Set 41: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Patch Set 41:
(13 comments)
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 7: *some* Why only some? Why the stressing? Is there a programmer that does not work?
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 18: # Does s3resume work?
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 25: detection Only detection? What about the rest, like, ECC getting enabled? It either works, it doesn't, or your CPU can't make use of ECC memory, so untested.
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 38: (acpi, src/mainboard/gigabyte/ga-h61m-s2pv/acpi/thermal.asl maybe?) It's acpi, but don't do a copypasta from a copypasta please.
If vendor firmware makes LNXTHERM appear, then look at the vendor DSDT and check if there's anything that exists in coreboot already
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 39: PCI function 4 swapped to 0 (huh?) : - PCI function 2 swapped to 0 (huh?) Coalescing, very likely. But who knows what this means if the affected PCI device is not mentioned?
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 41: - register differences to vendor firmare: : - BIOS_PCI_EXP_EN 1->0 : - PCI_EXP_EN 1->0 : - GPIO_TIER2_SCI_EN 1->0 And why is this an issue, exactly?
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 46: ## ToDo : : - Fix issues above : - Fix TODOs mentioned in code That's rather obvious, I'd say.
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 50: - Validate slp registers : - Validate usb settings in devicetree Validate how?
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 78: : +------------------+--------------------------------------------------+ : | Other slots | 1x RS232 (ext) | : | | 1x RS232 header | : | | 1x TPM header | : | | 1x Power SMB header | : | | 5x PWM Fan connector | : | | 2x I-SGPIO | : | | 2x S-ATA DOM Power connector | : | | 1x XDP Port | : | | 1x External BMC I2C Header (for IPMI card) | : | | 1x Chassis Intrusion Header | : +------------------+--------------------------------------------------+ If you link the vendor's device page, I don't think you need to copypasta that information here.
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h:
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... PS41, Line 17: struct device; What's this?
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... PS41, Line 22: void variant_mainboard_init(struct device *dev) should be on the previous line
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... PS41, Line 27: : /* do common init */ : // placeholder for common mainboard initialization Why these comments?
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... PS41, Line 24: Find out why the polarities from gpio.h gets overwritten by FSP. Somewhere, it is stated that FSP overrides GPIO settings, and then coreboot has to restore them.
I think FSP has UPDs for GPIO configs, but who knows if they're even being used?
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#42).
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
mb/supermicro/x11-lga1151-series: add x11ssm-f board
This adds another x11 series board, the X11SSM-F, which is similiar to X11SSH-TF but differs in PCIe interfaces/devices, GPIO settings and Ethernet interfaces.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name M src/mainboard/supermicro/x11-lga1151-series/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h A src/mainboard/supermicro/x11-lga1151-series/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb 11 files changed, 576 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/42
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Patch Set 42:
(9 comments)
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 7: *some*
Why only some? Why the stressing? Is there a programmer that does not work?
was copied from x11ssh, fixed
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 18: #
Does s3resume work?
no
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 25: detection
Only detection? What about the rest, like, ECC getting enabled? It either works, it doesn't, or your […]
needs testing
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 38: (acpi, src/mainboard/gigabyte/ga-h61m-s2pv/acpi/thermal.asl maybe?)
It's acpi, but don't do a copypasta from a copypasta please. […]
This comment does not say anything about copypasta^^ This is just an example how this was done there... of course this needs more checking
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 39: PCI function 4 swapped to 0 (huh?) : - PCI function 2 swapped to 0 (huh?)
Coalescing, very likely. […]
right, removed
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 41: - register differences to vendor firmare: : - BIOS_PCI_EXP_EN 1->0 : - PCI_EXP_EN 1->0 : - GPIO_TIER2_SCI_EN 1->0
And why is this an issue, exactly?
because I didn't check what these are until now
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 46: ## ToDo : : - Fix issues above : - Fix TODOs mentioned in code
That's rather obvious, I'd say.
Ack
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 50: - Validate slp registers : - Validate usb settings in devicetree
Validate how?
checking datasheets, testing....
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 78: : +------------------+--------------------------------------------------+ : | Other slots | 1x RS232 (ext) | : | | 1x RS232 header | : | | 1x TPM header | : | | 1x Power SMB header | : | | 5x PWM Fan connector | : | | 2x I-SGPIO | : | | 2x S-ATA DOM Power connector | : | | 1x XDP Port | : | | 1x External BMC I2C Header (for IPMI card) | : | | 1x Chassis Intrusion Header | : +------------------+--------------------------------------------------+
If you link the vendor's device page, I don't think you need to copypasta that information here.
This was merged for x11ssh, so this should be here, too. Paul Menzel requested to show the differences
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Patch Set 42:
(8 comments)
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 38: (acpi, src/mainboard/gigabyte/ga-h61m-s2pv/acpi/thermal.asl maybe?)
This comment does not say anything about copypasta^^ This is just an example how this was done there […]
Done
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 39: PCI function 4 swapped to 0 (huh?) : - PCI function 2 swapped to 0 (huh?)
right, removed
Done
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 41: - register differences to vendor firmare: : - BIOS_PCI_EXP_EN 1->0 : - PCI_EXP_EN 1->0 : - GPIO_TIER2_SCI_EN 1->0
because I didn't check what these are until now
Done
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 46: ## ToDo : : - Fix issues above : - Fix TODOs mentioned in code
Ack
Done
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h:
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... PS41, Line 17: struct device;
What's this?
o.O I have no clue... removed
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... PS41, Line 22: void variant_mainboard_init(struct device *dev)
should be on the previous line
Done
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... PS41, Line 27: : /* do common init */ : // placeholder for common mainboard initialization
Why these comments?
IMHO a little bit of documentation is does not hurt, does it?
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... PS41, Line 24: Find out why the polarities from gpio.h gets overwritten by FSP.
Somewhere, it is stated that FSP overrides GPIO settings, and then coreboot has to restore them. […]
yeah, I don't even know if it's required to set them here :S
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#43).
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
mb/supermicro/x11-lga1151-series: add x11ssm-f board
This adds another x11 series board, the X11SSM-F, which is similiar to X11SSH-TF but differs in PCIe interfaces/devices, GPIO settings and Ethernet interfaces.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name M src/mainboard/supermicro/x11-lga1151-series/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h A src/mainboard/supermicro/x11-lga1151-series/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb 11 files changed, 574 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/43
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#44).
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
mb/supermicro/x11-lga1151-series: add x11ssm-f board
This adds another x11 series board, the X11SSM-F, which is similiar to X11SSH-TF but differs in PCIe interfaces/devices, GPIO settings and Ethernet interfaces.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name M src/mainboard/supermicro/x11-lga1151-series/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h A src/mainboard/supermicro/x11-lga1151-series/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb 11 files changed, 576 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/44
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#45).
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
mb/supermicro/x11-lga1151-series: add x11ssm-f board
This adds another x11 series board, the X11SSM-F, which is similiar to X11SSH-TF but differs in PCIe interfaces/devices, GPIO settings and Ethernet interfaces.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/supermicro/x11-lga1151-series/x11-lga1151-series.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name M src/mainboard/supermicro/x11-lga1151-series/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h A src/mainboard/supermicro/x11-lga1151-series/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb 12 files changed, 574 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/45
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Patch Set 45:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 25: detection
needs testing
tested and working; updated this
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Patch Set 45:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... PS41, Line 27: : /* do common init */ : // placeholder for common mainboard initialization
IMHO a little bit of documentation is does not hurt, does it?
Done
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Patch Set 45: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Patch Set 45:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 50: - Validate slp registers : - Validate usb settings in devicetree
checking datasheets, testing....
will check this in the next few days
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#46).
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
mb/supermicro/x11-lga1151-series: add x11ssm-f board
This adds another x11 series board, the X11SSM-F, which is similiar to X11SSH-TF but differs in PCIe interfaces/devices, GPIO settings and Ethernet interfaces.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/supermicro/x11-lga1151-series/x11-lga1151-series.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-f.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name M src/mainboard/supermicro/x11-lga1151-series/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h A src/mainboard/supermicro/x11-lga1151-series/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb 12 files changed, 570 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/46
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Uploaded patch set 46.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Uploaded patch set 47.
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#47).
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
mb/supermicro/x11-lga1151-series: add x11ssm-f board
This adds another x11 series board, the X11SSM-F, which is similiar to X11SSH-TF but differs in PCIe interfaces/devices, GPIO settings and Ethernet interfaces.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/supermicro/x11-lga1151-series/x11-lga1151-series.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-f.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name M src/mainboard/supermicro/x11-lga1151-series/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h A src/mainboard/supermicro/x11-lga1151-series/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb 12 files changed, 569 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/47
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35427
to look at the new patch set (#48).
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
mb/supermicro/x11-lga1151-series: add x11ssm-f board
This adds another x11 series board, the X11SSM-F, which is similiar to X11SSH-TF but differs in PCIe interfaces/devices, GPIO settings and Ethernet interfaces.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/supermicro/x11-lga1151-series/x11-lga1151-series.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-f.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name M src/mainboard/supermicro/x11-lga1151-series/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h A src/mainboard/supermicro/x11-lga1151-series/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb 12 files changed, 600 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/35427/48
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Uploaded patch set 48.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Patch Set 48:
This is ready for final review
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Patch Set 48:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 50: - Validate slp registers : - Validate usb settings in devicetree
will check this in the next few days
Done
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Patch Set 48: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Patch Set 48:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... PS41, Line 24: Find out why the polarities from gpio.h gets overwritten by FSP.
yeah, I don't even know if it's required to set them here :S
@Nico some idea here?
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Patch Set 48:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... PS41, Line 24: Find out why the polarities from gpio.h gets overwritten by FSP.
@Nico some idea here?
Are you sure the final values, when coreboot is done differ from the `gpio.h` settings? There is itss_snapshot|restore_irq_polarities() that are supposed to take care of it...
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Patch Set 48:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... PS41, Line 24: Find out why the polarities from gpio.h gets overwritten by FSP.
Are you sure the final values, when coreboot is done differ from the `gpio.h` […]
Ok, I think, I got it. It's the jumping back and forth of intel/ code that makes things too fragile. It seems the snapshot is taken before the GPIO settings are written. Doing anything beyond filling parameters in mainboard_silicon_init_params() seems like a bad idea.
IIRC, I even ended up applying GPIO settings only after silicon init run on at least one board. Maybe it's time to make GPIO configuration a clear step of the soc/ control flow?
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Patch Set 48: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/41/src/mainboard/supermicro/x... PS41, Line 24: Find out why the polarities from gpio.h gets overwritten by FSP.
Ok, I think, I got it. It's the jumping back and forth of intel/ code […]
I close this for now, as the board is working in the current state; we should find a solution for itss anyways
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
mb/supermicro/x11-lga1151-series: add x11ssm-f board
This adds another x11 series board, the X11SSM-F, which is similiar to X11SSH-TF but differs in PCIe interfaces/devices, GPIO settings and Ethernet interfaces.
Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/35427 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: Michael Niewöhner --- M Documentation/mainboard/supermicro/x11-lga1151-series/x11-lga1151-series.md A Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-f.md M src/mainboard/supermicro/x11-lga1151-series/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig.name M src/mainboard/supermicro/x11-lga1151-series/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h A src/mainboard/supermicro/x11-lga1151-series/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb 12 files changed, 600 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved Michael Niewöhner: Looks good to me, but someone else must approve
diff --git a/Documentation/mainboard/supermicro/x11-lga1151-series/x11-lga1151-series.md b/Documentation/mainboard/supermicro/x11-lga1151-series/x11-lga1151-series.md index 8c99527..3ba4c3f 100644 --- a/Documentation/mainboard/supermicro/x11-lga1151-series/x11-lga1151-series.md +++ b/Documentation/mainboard/supermicro/x11-lga1151-series/x11-lga1151-series.md @@ -7,6 +7,7 @@ ## Supported boards
- [X11SSH-TF](x11ssh-tf/x11ssh-tf.md) +- [X11SSM-F](x11ssh-tf/x11ssm-f.md)
## Required proprietary blobs
@@ -30,6 +31,7 @@ These issues apply to all boards. Have a look at the board-specific issues, too.
- TianoCore doesn't work with Aspeed NGI, as it's text mode only (Fix is WIP CB:35726) +- MRC caching does not work with cold boot
## ToDo
diff --git a/Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-f.md b/Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-f.md new file mode 100644 index 0000000..5213bce --- /dev/null +++ b/Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-f.md @@ -0,0 +1,93 @@ +# Supermicro X11SSM-F + +This section details how to run coreboot on the [Supermicro X11SSM-F]. + +## Flashing coreboot + +The board can be flashed externally. FTDI FT2232H and FT232H based programmers worked. + +The flash IC [MX25L12873F] can be found near PCH PCIe Slot 4. It is socketed on retail boards. + +For doing ISP (In-System-Programming) one needs to add a diode between VCC and the flash chip. + +## BMC (IPMI) + +This board has an ASPEED [AST2400], which has BMC/[IPMI] functionality. The BMC firmware resides in a +32 MiB SOIC-16 chip in the corner of the mainboard near the PCH PCIe Slot 4. This chip is a +[MX25L25635F]. + +## Tested and working + +- GRUB2 payload with Debian testing and kernel 5.2 +- ECC ram (Linux' ie31200 driver works) +- USB ports +- Ethernet +- SATA ports +- RS232 external +- PCIe slots +- BMC (IPMI) +- VGA on Aspeed +- TPM on TPM expansion header + +## Known issues + +- See general issue section +- "only partially covers this bridge" info from Linux kernel (what does that mean?) +- LNXTHERM missing +- S3 resume not working + +## ToDo + +- Fix TODOs mentioned in code + +## Technology + +```eval_rst ++------------------+--------------------------------------------------+ +| CPU | Intel Kaby Lake | ++------------------+--------------------------------------------------+ +| PCH | Intel C236 | ++------------------+--------------------------------------------------+ +| Coprocessor | Intel SPS (server version of the ME) | ++------------------+--------------------------------------------------+ +| Super I/O | ASPEED AST2400 | ++------------------+--------------------------------------------------+ +| Ethernet | 2x Intel I210-AT 1 GbE | +| | 1x dedicated BMC | ++------------------+--------------------------------------------------+ +| PCIe slots | 1x 3.0 x8 | +| | 1x 3.0 x8 (in x16) | +| | 2x 3.0 x4 (in x8) | ++------------------+--------------------------------------------------+ +| USB slots | 2x USB 2.0 (ext) | +| | 2x USB 3.0 (ext) | +| | 1x USB 3.0 (int) | +| | 1x dual USB 3.0 header | +| | 2x dual USB 2.0 header | ++------------------+--------------------------------------------------+ +| SATA slots | 8x S-ATA III | ++------------------+--------------------------------------------------+ +| Other slots | 1x RS232 (ext) | +| | 1x RS232 header | +| | 1x TPM header | +| | 1x Power SMB header | +| | 5x PWM Fan connector | +| | 2x I-SGPIO | +| | 2x S-ATA DOM Power connector | +| | 1x XDP Port | +| | 1x External BMC I2C Header (for IPMI card) | +| | 1x Chassis Intrusion Header | ++------------------+--------------------------------------------------+ +``` + +## Extra links + +- [Supermicro X11SSM-F] +- [Board manual] + +[Supermicro X11SSM-F]: https://www.supermicro.com/en/products/motherboard/X11SSM-F +[Board manual]: https://www.supermicro.com/manuals/motherboard/C236/MNL-1785.pdf +[AST2400]: https://www.aspeedtech.com/products.php?fPath=20&rId=376 +[IPMI]: ../../../../drivers/ipmi_kcs.md +[MX25L25635F]: https://media.digikey.com/pdf/Data%20Sheets/Macronix/MX25L25635F.pdf +[MX25L12873F]: https://media.digikey.com/pdf/Data%20Sheets/Macronix/MX25L12873F.pdf diff --git a/src/mainboard/supermicro/x11-lga1151-series/Kconfig b/src/mainboard/supermicro/x11-lga1151-series/Kconfig index 541b23d..329cfd9 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/Kconfig +++ b/src/mainboard/supermicro/x11-lga1151-series/Kconfig @@ -22,6 +22,7 @@ config MAINBOARD_PART_NUMBER string default "X11SSH-TF" if BOARD_SUPERMICRO_X11SSH_TF + default "X11SSM-F" if BOARD_SUPERMICRO_X11SSM_F
config MAINBOARD_DIR string @@ -30,6 +31,7 @@ config VARIANT_DIR string default "x11ssh-tf" if BOARD_SUPERMICRO_X11SSH_TF + default "x11ssm-f" if BOARD_SUPERMICRO_X11SSM_F
config OVERRIDE_DEVICETREE string diff --git a/src/mainboard/supermicro/x11-lga1151-series/Kconfig.name b/src/mainboard/supermicro/x11-lga1151-series/Kconfig.name index ec01b13..7b2eaaf 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/Kconfig.name +++ b/src/mainboard/supermicro/x11-lga1151-series/Kconfig.name @@ -1,3 +1,7 @@ config BOARD_SUPERMICRO_X11SSH_TF bool "X11SSH-TF" select BOARD_SUPERMICRO_BASEBOARD_X11_LGA1151_SERIES + +config BOARD_SUPERMICRO_X11SSM_F + bool "X11SSM-F" + select BOARD_SUPERMICRO_BASEBOARD_X11_LGA1151_SERIES diff --git a/src/mainboard/supermicro/x11-lga1151-series/Makefile.inc b/src/mainboard/supermicro/x11-lga1151-series/Makefile.inc index a6d789e..cab662a 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/Makefile.inc +++ b/src/mainboard/supermicro/x11-lga1151-series/Makefile.inc @@ -18,5 +18,7 @@
ramstage-y += ramstage.c
+CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/include + subdirs-y += variants/$(VARIANT_DIR) CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/include diff --git a/src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h b/src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h new file mode 100644 index 0000000..a2047d4 --- /dev/null +++ b/src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h @@ -0,0 +1,21 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the + * GNU General Public License for more details. + */ + +#ifndef _BASEBOARD_X11_LGA1151_SERIES_H +#define _BASEBOARD_X11_LGA1151_SERIES_H + +#include <device/device.h> + +void variant_mainboard_init(struct device *dev); + +#endif /* _BASEBOARD_X11_LGA1151_SERIES_H */ diff --git a/src/mainboard/supermicro/x11-lga1151-series/mainboard.c b/src/mainboard/supermicro/x11-lga1151-series/mainboard.c new file mode 100644 index 0000000..750c856 --- /dev/null +++ b/src/mainboard/supermicro/x11-lga1151-series/mainboard.c @@ -0,0 +1,41 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2007-2009 coresystems GmbH + * Copyright (C) 2013 Google Inc. + * Copyright (C) 2016 Intel Corporation. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <mainboard.h> +#include <device/device.h> + +__weak void variant_mainboard_init(struct device *dev) +{ +} + +static void mainboard_init(struct device *dev) +{ + /* do common init */ + // placeholder for common mainboard initialization + + /* do variant init */ + variant_mainboard_init(dev); +} + +static void mainboard_enable(struct device *dev) +{ + dev->ops->init = mainboard_init; +} + +struct chip_operations mainboard_ops = { + .enable_dev = mainboard_enable, +}; diff --git a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc new file mode 100644 index 0000000..f3c87b2 --- /dev/null +++ b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc @@ -0,0 +1 @@ +ramstage-y += mainboard.c diff --git a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt new file mode 100644 index 0000000..a914412 --- /dev/null +++ b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/board_info.txt @@ -0,0 +1,7 @@ +Category: server +Vendor name: Supermicro +Board name: X11SSM-F +Board URL: https://www.supermicro.com/en/products/motherboard/X11SSM-F +ROM protocol: SPI +ROM socketed: y +Flashrom support: y diff --git a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h new file mode 100644 index 0000000..6a25128 --- /dev/null +++ b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h @@ -0,0 +1,269 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2018 Intel Corporation. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the + * GNU General Public License for more details. + */ + +#ifndef _GPIO_X11SSM_F_H +#define _GPIO_X11SSM_F_H + +#include <soc/gpe.h> +#include <soc/gpio.h> + +static const struct pad_config gpio_table[] = { + /* GPIO Group GPP_A */ + _PAD_CFG_STRUCT(GPP_A0, 0x44000700, 0x00000010), /* RCIN# */ + _PAD_CFG_STRUCT(GPP_A1, 0x44000700, 0x00000010), /* LAD0 */ + _PAD_CFG_STRUCT(GPP_A2, 0x44000700, 0x00000010), /* LAD1 */ + _PAD_CFG_STRUCT(GPP_A3, 0x44000700, 0x00000010), /* LAD2 */ + _PAD_CFG_STRUCT(GPP_A4, 0x44000700, 0x00000010), /* LAD3 */ + _PAD_CFG_STRUCT(GPP_A5, 0x44000700, 0x00000010), /* LFRAME# */ + _PAD_CFG_STRUCT(GPP_A6, 0x44000700, 0x00000010), /* SERIRQ */ + _PAD_CFG_STRUCT(GPP_A7, 0x44000700, 0x00000010), /* PIRQA# */ + _PAD_CFG_STRUCT(GPP_A8, 0x44000700, 0x00000010), /* CLKRUN# */ + _PAD_CFG_STRUCT(GPP_A9, 0x44000700, 0x00000010), /* CLKOUT_LPC0 */ + _PAD_CFG_STRUCT(GPP_A10, 0x44000700, 0x00000010), /* CLKOUT_LPC1 */ + _PAD_CFG_STRUCT(GPP_A11, 0x44000700, 0x00000010), /* PME# */ + _PAD_CFG_STRUCT(GPP_A12, 0x84000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_A13, 0x44000700, 0x00000010), /* SUSWARN#/SUSPWRDNACK */ + _PAD_CFG_STRUCT(GPP_A14, 0x44000700, 0x00000010), /* SUS_STAT# */ + _PAD_CFG_STRUCT(GPP_A15, 0x44000700, 0x00000010), /* SUS_ACK# */ + _PAD_CFG_STRUCT(GPP_A16, 0x44000700, 0x00000010), /* CLKOUT_48 */ + _PAD_CFG_STRUCT(GPP_A17, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_A18, 0x84000100, 0x00000010), /* GPIO */ + /* reserved */ + //_PAD_CFG_STRUCT(GPP_A19, 0xffffffff, 0xffffffff), /* ISH_GP1 */ + _PAD_CFG_STRUCT(GPP_A20, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_A21, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_A22, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_A23, 0x44000300, 0x00000010), /* GPIO */ + + /* GPIO Group GPP_B */ + _PAD_CFG_STRUCT(GPP_B0, 0x44000201, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_B1, 0x44000201, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_B2, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_B3, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_B4, 0x44000301, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_B5, 0x44000301, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_B6, 0x84000301, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_B7, 0x44000301, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_B8, 0x44000301, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_B9, 0x44000301, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_B10, 0x44000301, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_B11, 0x44000200, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_B12, 0x44000700, 0x00000010), /* SLP_S0# */ + _PAD_CFG_STRUCT(GPP_B13, 0x44000700, 0x00000010), /* PLTRST# */ + _PAD_CFG_STRUCT(GPP_B14, 0x84000700, 0x00000010), /* SPKR */ + _PAD_CFG_STRUCT(GPP_B15, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_B16, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_B17, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_B18, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_B19, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_B20, 0x84000201, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_B21, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_B22, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_B23, 0x40000b00, 0x00000010), /* PCHHOT# */ + + /* GPIO Group GPP_C */ + /* reserved */ + //_PAD_CFG_STRUCT(GPP_C0, 0x44000700, 0x00000010), /* SMBCLK */ + //_PAD_CFG_STRUCT(GPP_C1, 0x44000700, 0x00000010), /* SMBDATA */ + _PAD_CFG_STRUCT(GPP_C2, 0x44000300, 0x00000010), /* GPIO */ + /* reserved */ + //_PAD_CFG_STRUCT(GPP_C3, 0x44000700, 0x00000010), /* SML0CLK */ + //_PAD_CFG_STRUCT(GPP_C4, 0x44000700, 0x00000010), /* SML0DATA */ + _PAD_CFG_STRUCT(GPP_C5, 0x44000201, 0x00000010), /* GPIO */ + /* reserved */ + //_PAD_CFG_STRUCT(GPP_C6, 0x44000700, 0x00000010), /* SML1CLK */ + //_PAD_CFG_STRUCT(GPP_C7, 0x44000700, 0x00000010), /* SML1DATA */ + _PAD_CFG_STRUCT(GPP_C8, 0x84000100, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_C9, 0x84000100, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_C10, 0x84000100, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_C11, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_C12, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_C13, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_C14, 0x84000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_C15, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_C16, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_C17, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_C18, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_C19, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_C20, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_C21, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_C22, 0x42040100, 0x00003010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_C23, 0x84000300, 0x00000010), /* GPIO */ + + /* GPIO Group GPP_D */ + _PAD_CFG_STRUCT(GPP_D0, 0x84000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_D1, 0x44000201, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_D2, 0x42020100, 0x00003000), /* GPIO */ + _PAD_CFG_STRUCT(GPP_D3, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_D4, 0x84000200, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_D5, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_D6, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_D7, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_D8, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_D9, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_D10, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_D11, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_D12, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_D13, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_D14, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_D15, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_D16, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_D17, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_D18, 0x84000201, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_D19, 0x84000201, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_D20, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_D21, 0x44000200, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_D22, 0x04000100, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_D23, 0x44000300, 0x00000010), /* GPIO */ + + /* GPIO Group GPP_E */ + _PAD_CFG_STRUCT(GPP_E0, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_E1, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_E2, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_E3, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_E4, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_E5, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_E6, 0x82020100, 0x00003000), /* GPIO */ + _PAD_CFG_STRUCT(GPP_E7, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_E8, 0x44000700, 0x00000010), /* SATA_LED# */ + _PAD_CFG_STRUCT(GPP_E9, 0x44000700, 0x00000010), /* USB_OC0# */ + _PAD_CFG_STRUCT(GPP_E10, 0x44000700, 0x00000010), /* USB_OC1# */ + _PAD_CFG_STRUCT(GPP_E11, 0x44000700, 0x00000010), /* USB_OC2# */ + _PAD_CFG_STRUCT(GPP_E12, 0x44000700, 0x00000010), /* USB_OC3# */ + + /* GPIO Group GPP_F */ + _PAD_CFG_STRUCT(GPP_F0, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_F1, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_F2, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_F3, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_F4, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_F5, 0x80100100, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_F6, 0x84000201, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_F7, 0x84000201, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_F8, 0x84000201, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_F9, 0x84000100, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_F10, 0x44000700, 0x00000010), /* SATA_SCLOCK */ + _PAD_CFG_STRUCT(GPP_F11, 0x44000700, 0x00000010), /* SATA_SLOAD */ + _PAD_CFG_STRUCT(GPP_F12, 0x44000700, 0x00000010), /* SATA_SDATAOUT1 */ + _PAD_CFG_STRUCT(GPP_F13, 0x44000700, 0x00000010), /* SATA_SDATAOUT2 */ + _PAD_CFG_STRUCT(GPP_F14, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_F15, 0x44000700, 0x00000010), /* USB_OC4# */ + _PAD_CFG_STRUCT(GPP_F16, 0x44000700, 0x00000010), /* USB_OC5# */ + _PAD_CFG_STRUCT(GPP_F17, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_F18, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_F19, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_F20, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_F21, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_F22, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_F23, 0x04000200, 0x00000010), /* GPIO */ + + /* GPIO Group GPP_G */ + _PAD_CFG_STRUCT(GPP_G0, 0x44000100, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_G1, 0x44000100, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_G2, 0x44000100, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_G3, 0x44000100, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_G4, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_G5, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_G6, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_G7, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_G8, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_G9, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_G10, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_G11, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_G12, 0x84000100, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_G13, 0x84000100, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_G14, 0x84000100, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_G15, 0x84000100, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_G16, 0x84000100, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_G17, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_G18, 0x44000700, 0x00000010), /* NMI# */ + _PAD_CFG_STRUCT(GPP_G19, 0x44000700, 0x00000010), /* SMI# */ + _PAD_CFG_STRUCT(GPP_G20, 0x44000300, 0x00000000), /* GPIO */ + _PAD_CFG_STRUCT(GPP_G21, 0x44000300, 0x00000000), /* GPIO */ + _PAD_CFG_STRUCT(GPP_G22, 0x44000300, 0x00000000), /* GPIO */ + _PAD_CFG_STRUCT(GPP_G23, 0x44000300, 0x00000010), /* GPIO */ + + /* GPIO Group GPP_H */ + _PAD_CFG_STRUCT(GPP_H0, 0x44000201, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_H1, 0x84000101, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_H2, 0x44000201, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_H3, 0x44000201, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_H4, 0x84000101, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_H5, 0x84000201, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_H6, 0x84000201, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_H7, 0x84000201, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_H8, 0x84000201, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_H9, 0x84000201, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_H10, 0x44000700, 0x00000010), /* SML2CLK */ + _PAD_CFG_STRUCT(GPP_H11, 0x44000700, 0x00000010), /* SML2DATA */ + _PAD_CFG_STRUCT(GPP_H12, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_H13, 0x44000700, 0x00000010), /* SML3CLK */ + _PAD_CFG_STRUCT(GPP_H14, 0x44000700, 0x00000010), /* SML3DATA */ + _PAD_CFG_STRUCT(GPP_H15, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_H16, 0x44000700, 0x00000010), /* SML4CLK */ + _PAD_CFG_STRUCT(GPP_H17, 0x44000700, 0x00000010), /* SML4DATA */ + _PAD_CFG_STRUCT(GPP_H18, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_H19, 0x84000201, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_H20, 0x84000201, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_H21, 0x84000201, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_H22, 0x84000201, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_H23, 0x84000201, 0x00000010), /* GPIO */ + + /* GPIO Group GPP_I */ + _PAD_CFG_STRUCT(GPP_I0, 0x44000700, 0x00000010), /* DDPB_HPD0 */ + _PAD_CFG_STRUCT(GPP_I1, 0x44000700, 0x00000010), /* DDPC_HPD1 */ + _PAD_CFG_STRUCT(GPP_I2, 0x44000700, 0x00000010), /* DDPD_HPD2 */ + _PAD_CFG_STRUCT(GPP_I3, 0x84000700, 0x00000010), /* DDPE_HPD3 */ + _PAD_CFG_STRUCT(GPP_I4, 0x44000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPP_I5, 0x44000700, 0x00000010), /* DDPB_CTRLCLK */ + _PAD_CFG_STRUCT(GPP_I6, 0x44000700, 0x00000010), /* DDPB_CTRLDATA */ + _PAD_CFG_STRUCT(GPP_I7, 0x44000700, 0x00000010), /* DDPC_CTRLCLK */ + _PAD_CFG_STRUCT(GPP_I8, 0x44000700, 0x00000010), /* DDPC_CTRLDATA */ + _PAD_CFG_STRUCT(GPP_I9, 0x44000700, 0x00000010), /* DDPD_CTRLCLK */ + _PAD_CFG_STRUCT(GPP_I10, 0x44000700, 0x00000010), /* DDPD_CTRLDATA */ + + /* GPIO Group GPD */ + _PAD_CFG_STRUCT(GPD0, 0x04000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPD1, 0x04000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPD2, 0x04000700, 0x00000010), /* LAN_WAKE# */ + _PAD_CFG_STRUCT(GPD3, 0x04000700, 0x00000010), /* PWRBTN# */ + _PAD_CFG_STRUCT(GPD4, 0x04000700, 0x00000010), /* SLP_S3# */ + _PAD_CFG_STRUCT(GPD5, 0x04000700, 0x00000010), /* SLP_S4# */ + _PAD_CFG_STRUCT(GPD6, 0x04000700, 0x00000010), /* SLP_A# */ + _PAD_CFG_STRUCT(GPD7, 0x04000301, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPD8, 0x04000700, 0x00000010), /* SUSCLK */ + _PAD_CFG_STRUCT(GPD9, 0x04000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPD10, 0x04000300, 0x00000010), /* GPIO */ + _PAD_CFG_STRUCT(GPD11, 0x04000300, 0x00000010), /* GPIO */ +}; + +/* Early pad configuration in romstage. */ +static const struct pad_config early_gpio_table[] = { + /* GPIO Group GPP_A */ + /* LPC */ + _PAD_CFG_STRUCT(GPP_A1, 0x44000700, 0x00000010), /* LAD0 */ + _PAD_CFG_STRUCT(GPP_A2, 0x44000700, 0x00000010), /* LAD1 */ + _PAD_CFG_STRUCT(GPP_A3, 0x44000700, 0x00000010), /* LAD2 */ + _PAD_CFG_STRUCT(GPP_A4, 0x44000700, 0x00000010), /* LAD3 */ + _PAD_CFG_STRUCT(GPP_A5, 0x44000700, 0x00000010), /* LFRAME# */ + _PAD_CFG_STRUCT(GPP_A8, 0x44000700, 0x00000010), /* CLKRUN# */ + _PAD_CFG_STRUCT(GPP_A9, 0x44000700, 0x00000010), /* CLKOUT_LPC0 */ + _PAD_CFG_STRUCT(GPP_A10, 0x44000700, 0x00000010), /* CLKOUT_LPC1 */ + + /* Serial interrupt */ + _PAD_CFG_STRUCT(GPP_A6, 0x44000700, 0x00000010), /* SERIRQ */ +}; + +#endif /* _GPIO_X11SSM_F_H */ diff --git a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c new file mode 100644 index 0000000..7cf8883 --- /dev/null +++ b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c @@ -0,0 +1,34 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <mainboard.h> +#include <device/device.h> +#include <intelblocks/itss.h> +#include <intelblocks/pcr.h> +#include <soc/itss.h> +#include <soc/pcr_ids.h> + +void variant_mainboard_init(struct device *dev) +{ + /* TODO: + * Find out why the polarities from gpio.h gets overwritten by FSP. + * This sets irq polarity to the same values as vendor + * but I do not know if this is really needed.... + */ + itss_set_irq_polarity(33, 0); + itss_set_irq_polarity(34, 0); + + // TODO: NMI; is this needed? vendor sets it + pcr_write32(0xae, 0x01e4, 0x00000004); + pcr_write32(0xae, 0x01e8, 0x00000040); +} diff --git a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb new file mode 100644 index 0000000..ea90e0b --- /dev/null +++ b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb @@ -0,0 +1,124 @@ +chip soc/intel/skylake + + # GPE configuration + # Note that GPE events called out in ASL code rely on this + # route. i.e. If this route changes then the affected GPE + # offset bits also need to be changed. + register "gpe0_dw0" = "GPP_G" + register "gpe0_dw1" = "GPP_D" + register "gpe0_dw2" = "GPP_E" + + register "gen1_dec" = "0x007c0a01" # Super IO SWC + register "gen2_dec" = "0x000c0ca1" # IPMI KCS + register "gen3_dec" = "0x000c03e1" # UART3 + register "gen4_dec" = "0x000c02e1" # UART4 + + # PCIe configuration + register "PcieRpEnable[0]" = "1" # Enable PCH PCIe Port 1 / PCH SLOT4 + register "PcieRpEnable[4]" = "1" # Enable PCH PCIe Port 5 / PCH SLOT5 + register "PcieRpEnable[8]" = "1" # Enable PCH PCIe Port 9 / GbE 1 + register "PcieRpEnable[9]" = "1" # Enable PCH PCIe Port 10 / GbE 2 + register "PcieRpEnable[10]" = "1" # Enable PCH PCIe Port 11 / Aspeed 2400 VGA + + # USB configuration + # USB0/1 + register "usb2_ports[5]" = "USB2_PORT_MID(OC2)" + register "usb2_ports[4]" = "USB2_PORT_MID(OC2)" + + # USB2/3 + register "usb2_ports[3]" = "USB2_PORT_MID(OC1)" + register "usb2_ports[2]" = "USB2_PORT_MID(OC1)" + + # USB4/5 + register "usb2_ports[7]" = "USB2_PORT_MID(OC0)" + register "usb2_ports[6]" = "USB2_PORT_MID(OC0)" + + # USB6/7 (USB3.0) + register "usb2_ports[11]" = "USB2_PORT_MID(OC4)" + register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC4)" + register "usb2_ports[10]" = "USB2_PORT_MID(OC4)" + register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC4)" + + # USB8/9 (USB3.0) + register "usb2_ports[1]" = "USB2_PORT_MID(OC3)" + register "usb3_ports[4]" = "USB3_PORT_DEFAULT(OC3)" + register "usb2_ports[0]" = "USB2_PORT_MID(OC3)" + register "usb3_ports[3]" = "USB3_PORT_DEFAULT(OC3)" + + # USB10 (USB3.0) + register "usb2_ports[9]" = "USB2_PORT_MID(OC5)" + register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC5)" + + # IPMI USB HUB + register "usb2_ports[8]" = "USB2_PORT_MID(OC_SKIP)" + + device domain 0 on + device pci 01.0 on # CPU PCIe Port (x16) / PCIe Slot 6 (JPCIE6) + smbios_slot_desc "SlotTypePciExpressGen3X16" "SlotLengthLong" "CPU SLOT6 PCI-E 3.0 X8(IN X16)" "SlotDataBusWidth8X" + end + device pci 01.1 on # CPU PCIe Port (x8) / PCIe Slot 7 (JPCIE7) + smbios_slot_desc "SlotTypePciExpressGen3X8" "SlotLengthShort" "CPU SLOT7 PCI-E 3.0 X8" "SlotDataBusWidth8X" + end + device pci 1c.0 on # PCH PCIe Port 1 / PCIe Slot 4 (JPCIE4) + smbios_slot_desc "SlotTypePciExpressGen3X8" "SlotLengthShort" "PCH SLOT4 PCI-E 3.0 X4(IN X8)" "SlotDataBusWidth4X" + end + device pci 1c.4 on # PCH PCIe Port 5 / PCIe Slot 5 (JPCIE5) + smbios_slot_desc "SlotTypePciExpressGen3X8" "SlotLengthShort" "PCH SLOT5 PCI-E 3.0 X4(IN X8)" "SlotDataBusWidth4X" + end + device pci 1d.0 on # PCH PCIe Port 9 + device pci 00.0 on end # GbE 1 + end + device pci 1d.1 on # PCH PCIe Port 10 + device pci 00.1 on end # GbE 2 + end + device pci 1d.2 on # PCH PCIe Port 11 + device pci 00.0 on # Aspeed PCI Bridge + device pci 00.0 on end # Aspeed 2400 VGA + end + end + device pci 1f.0 on # LPC Interface + chip drivers/ipmi + # On cold boot it takes a while for the BMC to start the IPMI service + register "wait_for_bmc" = "1" + register "bmc_boot_timeout" = "60" + device pnp ca2.0 on end # IPMI KCS + end + chip superio/common + device pnp 2e.0 on + chip superio/aspeed/ast2400 + device pnp 2e.2 on # SUART1 / COM1 (ext) + io 0x60 = 0x3f8 + irq 0x70 = 4 + end + device pnp 2e.3 on # SUART2 / COM2 (int) + io 0x60 = 0x2f8 + irq 0x70 = 3 + end + device pnp 2e.4 on # SWC + io 0x60 = 0xa00 + io 0x62 = 0xa10 + io 0x64 = 0xa20 + io 0x66 = 0xa30 + irq 0x70 = 0xb + end + device pnp 2e.5 off end # KBC + device pnp 2e.7 on end # GPIO + device pnp 2e.b on # SUART3 + io 0x60 = 0x3e8 + irq 0x70 = 4 + end + device pnp 2e.c on # SUART4 + io 0x60 = 0x2e8 + irq 0x70 = 3 + end + device pnp 2e.d on end # iLPC2AHB + device pnp 2e.e on # Mailbox + io 0x60 = 0xa40 + irq 0x70 = 0x00 + end + end + end + end + end + end +end
-
Angel Pons (Code Review) -
build bot (Jenkins) (Code Review)
-
Christian Walter (Code Review)
-
Kyösti Mälkki (Code Review)
-
Michael Niewöhner (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)