Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42745 )
Change subject: soc/intel: Configure PAVP at compile-time ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42745/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42745/5//COMMIT_MSG@11 PS5, Line 11:
What is the FSP default? […]
FSP defaults it to enabled. Is there merit in changing the default? I tried to address some pros and cons in the help text.
https://review.coreboot.org/c/coreboot/+/42745/5/src/soc/intel/common/Kconfi... File src/soc/intel/common/Kconfig.common:
https://review.coreboot.org/c/coreboot/+/42745/5/src/soc/intel/common/Kconfi... PS5, Line 40: Set this option to n to disable support
Please add a dot/period at the end.
Done
https://review.coreboot.org/c/coreboot/+/42745/5/src/soc/intel/common/Kconfi... PS5, Line 33: config PAVP : bool "Enable PAVP (Protected Audio-Video Path) support" : default y : help : Protected Audio-Video Path is an Intel technology used to enforce : digital rights protections on multimedia content. : : Set this option to n to disable support
Could you please extend this a little bit, why disabling this option might be wanted? Will it save e […]
Done? It may not merit inclusion, but I noticed that between CSME 11.0 and 11.8 (1.5 MB - Consumer), "pavp" became the only encrypted module.
-
Benjamin Doron (Code Review)