Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal.
Kun Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74475 )
Change subject: mb/google/rex: Initial setup for ramstage/early gpio config ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74475/comment/5894a75b_545e0ac2 PS1, Line 9: This adds the initial gpio configuration for the screebo initial variant.
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Please fix.
File src/mainboard/google/rex/variants/screebo/gpio.c:
https://review.coreboot.org/c/coreboot/+/74475/comment/77f18806_b19c164d PS1, Line 39: PAD_CFG_NF(GPP_A21, NONE, DEEP, NF1),
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/74475/comment/4f1ed431_1ab4315b PS1, Line 65: PAD_CFG_NF_LOCK(GPP_B11, NONE, NF1, LOCK_CONFIG),
trailing whitespace
Please fix.