Attention is currently required from: Jérémy Compostella.
Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84402?usp=email )
Change subject: efi: Set EFIAPI to 32-bit ABI for FSP1_1 ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84402/comment/3aa6f666_c8b1d6cb?usp... : PS2, Line 7: FSP1_1
Technically this is not mandatory: "Test your patches before submitting them to gerrit. It’s also appreciated if you add a line to the commit message describing how the patch was tested. This prevents people from having to ask whether and how the patch was tested."
I tend to agree we should have one as much as possible, it just does not make sense here but since I am always concerned that you won't let us land a patch not to your liking I am going to add a line for this.
Please avoid making such a comment, there is nothing personal. corebootis Gerrit test will be lost over time and we need to know while doing git bisect why one has added a one CL and what is the minimal testing being done.
**since I am always concerned that you won't let us land a patch not to your liking I am going to add a line for this.**
-
Subrata Banik (Code Review)