Attention is currently required from: Henry Sun, Paul2 Huang. Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59856 )
Change subject: mb/google/octopus: add audio codec into SSFC support for ApelE ......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/octopus/mainboard.c:
https://review.coreboot.org/c/coreboot/+/59856/comment/b24d8ead_755be3e7 PS4, Line 218: cfg->hid = "RTL5682"; Originally we expect overridetree.cb should give us a clear view of what candidate components are possible to be in this variant. For example, RT5682_VD / DS7219 / CS42L42 are candidates. Then SSFC can filter out others and keep the real candidate only.
This CL mixes the usage of SSFC and overridetree.cb together by changing the hid name here which is what we would like to avoid.
As a result, please make another object for VS in the overridetree.cb explicitly then manage it specifically here without touching VD object.
Since they are all using drivers_i2c_generic_ops, we can combine VD / VS into a if () like
if ((audio_dev->chip_ops == &drivers_i2c_generic_ops) { if (SSFC_VD && hid == 10EC5682) { .... }
if (SSFC_VS && hid == RTL5682) { .... } }