Caesar Wang has posted comments on this change. ( https://review.coreboot.org/19558 )
Change subject: google/gru: support 800M/928M frequency for bob
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/#/c/19558/6/src/mainboard/google/gru/sdram_confi...
File src/mainboard/google/gru/sdram_configs.c:
Line 39:
...and still you have two tables? The whole point of using snprintf was tha
Done
Line 53: ramcode = ram_code();
nit: would be better to factor out into a separate function, I think (i.e.
Done
--
To view, visit
https://review.coreboot.org/19558
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I613050292a09ff56f4636d7af285075e32259ef4
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Caesar Wang
wxt@rock-chips.com
Gerrit-Reviewer: Caesar Wang
wxt@rock-chips.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-HasComments: Yes