Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33759 )
Change subject: soc/amd/picasso: Create a hybrid romstage to begin in DRAM
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33759/9/src/soc/amd/picasso/reset_v...
File src/soc/amd/picasso/reset_vector.S:
https://review.coreboot.org/c/coreboot/+/33759/9/src/soc/amd/picasso/reset_v...
PS9, Line 111: .byte 0x00, 0x9b, 0xaf, 0x00
Do we need a romstage larger than 64KiB? If so, we can re-jigger that bit for bootblock too to ensur […]
So far I haven't needed it bigger than 64K but I specifically gave myself the option. Since FSP-M is its own separate cbfs file I still have over 27,000 bytes left.
Being explicit is probably a nice-to-have for all scenarios vs. assume 64K is always the max. I don't see it as a gating requirement though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33759
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id8c6175de34a0728ad41085e9c7cd310bd280976
Gerrit-Change-Number: 33759
Gerrit-PatchSet: 9
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 14 Aug 2019 22:36:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment