Attention is currently required from: Alexey Vazhnov, Paul Menzel. Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50368 )
Change subject: Document Gigabyte GA-G41M-ES2L ......................................................................
Patch Set 23: Code-Review+1
(9 comments)
File Documentation/mainboard/gigabyte/ga-g41m-es2l.md:
PS23: nit: we use 80 chars limit for lines of text (doesn't apply to code blocks) in documentation. I personally don't think this should stop docs from merging, but try to follow the common style in future.
https://review.coreboot.org/c/coreboot/+/50368/comment/e61f2830_2385c8f9 PS23, Line 21: GB Please, use "GiB" here. We're trying to use correct units in the documentation.
https://review.coreboot.org/c/coreboot/+/50368/comment/c651e892_d373e8b8 PS23, Line 209: 4.13-1531-g2fae1c0494 | 2021-01-28 | 2fae1c049407c11e The "coreboot version" and "last commit id" duplicate each other. The former could be dropped. If you look closely, you'll notice that the commit id is already a part of the coreboot version.
https://review.coreboot.org/c/coreboot/+/50368/comment/79637051_fce1ada8 PS23, Line 211: 62944355f3 There's no such commit in the tree. 62944355f3 was the (part of) commit hash of 11th patchset for this change.
https://review.coreboot.org/c/coreboot/+/50368/comment/eaf2c59e_44713e64 PS23, Line 211: -dirty The -dirty suffix just means that you had some uncommitted changes in your source tree at the time of building. It does not make sense in documentation.
https://review.coreboot.org/c/coreboot/+/50368/comment/5b2103cb_166f2741 PS23, Line 213: 5d51acb0d4 Again, no such commit. It was the commit hash of 16th patchset. This whole column is not needed and can be removed.
https://review.coreboot.org/c/coreboot/+/50368/comment/f522ce36_cf049c4f PS23, Line 249: GB GiB
https://review.coreboot.org/c/coreboot/+/50368/comment/fc3e81eb_8058e8a5 PS23, Line 250: GB GiB
https://review.coreboot.org/c/coreboot/+/50368/comment/acfad4d1_8464ca52 PS23, Line 264: GB GiB
-
Evgeny Zinoviev (Code Review)